chore: Add psalm for code analysis #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
chore/add-psalm
branch
from
9a745a9
to
1976c21
Compare
| @@ -148,7 +148,7 @@ public function load(int $id): Estimator { | |||
| } | |||
|
|
|||
| /** | |||
| * @param Estimator|Persistable $estimator | |||
| * @param Estimator $estimator (Must implement Persistable) | |||
There was a problem hiding this comment.
what about Estimator&Persistable? https://psalm.dev/docs/annotating_code/type_syntax/intersection_types/
There was a problem hiding this comment.
Can be done in a follow up, but this causes many issues as all functions also need to return the correct type.
susnux
force-pushed
the
chore/add-psalm
branch
from
1976c21
to
bb29721
Compare
ChristophWurst
approved these changes
Aug 20, 2024
susnux
force-pushed
the
chore/add-psalm
branch
5 times, most recently
from
8f7cf51
to
8a04581
Compare
This needs to be removed from the expected checks - it does not exist as we can only check 8.1+ |
susnux
force-pushed
the
chore/add-psalm
branch
3 times, most recently
from
00cda81
to
14dbeae
Compare
Fix all detected problem. There should be no¹ change in logic or behavior. ¹ Well one exception: If a suspicious login could not be persisted the code threw at some random place, so instead we handle this by notify the user and log that as critical severity. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/add-psalm
branch
from
14dbeae
to
6287e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705
Fix all detected problem.
There should be no¹ change in logic or behavior.
¹ Well one exception: If a suspicious login could not be persisted the code threw at some random place, so instead we handle this by notify the user and log that as critical severity.