Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Favorites): repair runtime cache population #1542

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 13, 2025

fixes #1350

The data was stored correctly, but the retrieval was borked.

@blizzz blizzz added bug Something isn't working 3. to review Waiting for reviews labels Jan 13, 2025
@blizzz blizzz requested review from juliusknorr and enjeck January 13, 2025 12:28
@blizzz
Copy link
Member Author

blizzz commented Jan 13, 2025

/backport to stable0.8

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 13, 2025
@blizzz blizzz force-pushed the fix/1350/favorites-cache branch from 37a06f1 to 9e483ef Compare January 13, 2025 12:30
@blizzz
Copy link
Member Author

blizzz commented Jan 13, 2025

Another funny thing: when i run tests locally this still fails, due to internationalization. It's british favourites locally, not favorites 🤪

@blizzz blizzz merged commit add3b2b into main Jan 13, 2025
54 checks passed
@blizzz blizzz deleted the fix/1350/favorites-cache branch January 13, 2025 19:06
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favorite/Unfavorite does not work properly
2 participants