Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown support #3176

Closed
10 tasks done
Tracked by #1027
nickvergessen opened this issue Jul 11, 2023 · 3 comments · Fixed by #3218
Closed
10 tasks done
Tracked by #1027

Markdown support #3176

nickvergessen opened this issue Jul 11, 2023 · 3 comments · Fixed by #3218
Assignees
@AndyScherzinger
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request feature: 🗨️ chat
Milestone
17.1.0

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Jul 11, 2023 •
edited by AndyScherzinger
Loading

We plan to role out the following support for markdown:

non-optional

  • bold
  • italic

optional

Optional means it is just shown with the markdown syntax

  • strike-through
  • list
  • todo list with checkboxes
  • code block using 3 `
  • inline code using `
  • quote
  • headlines
  • dividers ---
@nickvergessen nickvergessen added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) feature: 🗨️ chat labels Jul 11, 2023
@nickvergessen nickvergessen mentioned this issue Jul 11, 2023
Closed
7 tasks
@nickvergessen
Copy link
Member Author

I'm aware of #3154 just created a new ticket for tracking until we know whether we want to have an option for markdown on/off

@AndyScherzinger
Copy link
Member

@nickvergessen I checked the formatting list and ticket all boxes since the Android implementation supports all of them. Also adding an option to disable this completely should be very easy to do, only disabling parts is unlikely to work given the nature of the library in use.

@nickvergessen
Copy link
Member Author

There is a markdown property on messages now. If that is false, all Markdown rendering should be disabled:
nextcloud/spreed#10067

@AndyScherzinger AndyScherzinger mentioned this issue Jul 27, 2023
Merged
5 tasks
@AndyScherzinger AndyScherzinger added this to the 17.1.0 milestone Jul 28, 2023
@AndyScherzinger AndyScherzinger self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyScherzinger AndyScherzinger

Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request feature: 🗨️ chat
Projects
💬 Talk team
Archived in project
Milestone
17.1.0
Development

Successfully merging a pull request may close this issue.

Implement respecting the markdown rendering flag nextcloud/talk-android
2 participants
@nickvergessen @AndyScherzinger