Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement respecting the markdown rendering flag #3218

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Implement respecting the markdown rendering flag #3218

merged 1 commit into from
Jul 28, 2023

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jul 27, 2023 •
edited
Loading

...and fixing the reply ellipsizing for any reply messages

Resolves #3176

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 17.1.0 milestone Jul 27, 2023
@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Jul 27, 2023
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 28, 2023
@AndyScherzinger
Implement respecting the markdown rendering flag
c4290f1 
...and fixing the reply ellipsizing for any reply messages

Signed-off-by: Andy Scherzinger <[email protected]>
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3218-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

nickvergessen
nickvergessen approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AndyScherzinger AndyScherzinger merged commit 87cff6f into master Jul 28, 2023
13 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/3176/markdownFlag branch July 28, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mahibi mahibi mahibi approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 🗨️ chat
Projects
None yet
Milestone
17.1.0
Development

Successfully merging this pull request may close these issues.

Markdown support
3 participants
@AndyScherzinger @nickvergessen @mahibi