Select contacts from search #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowjanyakch
force-pushed
the
select_search_contacts
branch
from
5fa5232
to
817585f
Compare
mahibi
reviewed
Sep 10, 2024
| @@ -29,4 +29,8 @@ class FakeRepositorySuccess : ContactsRepository { | |||
| override fun getImageUri(avatarId: String, requestBigSize: Boolean): String { | |||
| return "https://mydomain.com/index.php/avatar/$avatarId/512" | |||
| } | |||
|
|
|||
| override fun getImageUri(avatarId: String, requestBigSize: Boolean): String { | |||
There was a problem hiding this comment.
Conflicting overloads because
override fun getImageUri(avatarId: String, requestBigSize: Boolean): String
already exists..?
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
not the best solution. Needs to be improved with theming of Compose. Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
select_search_contacts
branch
from
6ff1ff2
to
2549e88
Compare
|
/backport to stable-20.0 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4182-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following
🚧 TODO
🏁 Checklist
/backport to stable-xx.x