Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-20.0] Bugfix/3993/fix flickering unread mention popup #4189

Merged
merged 4 commits into from
Sep 11, 2024
Merged

[stable-20.0] Bugfix/3993/fix flickering unread mention popup #4189

merged 4 commits into from
Sep 11, 2024

Commits on Sep 11, 2024

  1. fix flickering of unread mention bubble 

    bug was introduced with #3417

Signed-off-by: Marcel Hibbe <[email protected]>
    @mahibi @backportbot
    mahibi authored and backportbot[bot] committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d150568 View commit details
    Browse the repository at this point in the history

  2. fix logic to show UnifiedSearch results when federation capability ex… 

    …ists

Signed-off-by: Marcel Hibbe <[email protected]>
    @mahibi @backportbot
    mahibi authored and backportbot[bot] committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    05bf66b View commit details
    Browse the repository at this point in the history

  3. fix to set searchBehaviorSubject regardless of searchHelper being not… 

    … null

same for swipeRefreshLayoutView?.isRefreshing

If searchHelper would be null (= when UnifiedSearch is not available) then going back to conversations list view would not trigger to check to show for unread mentions bubble. This fix will make it independent from searchHelper.

Signed-off-by: Marcel Hibbe <[email protected]>
    @mahibi @backportbot
    mahibi authored and backportbot[bot] committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    02be0d1 View commit details
    Browse the repository at this point in the history

  4. improve to align unread conversation after tapping on unread mentions… 

    … button

...instead to just show it on top

Signed-off-by: Marcel Hibbe <[email protected]>
    @mahibi @backportbot
    mahibi authored and backportbot[bot] committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    660d157 View commit details
    Browse the repository at this point in the history