-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation creation modification #4250
Conversation
93e643b
to
38e07e0
Compare
/backport to stable-20.0 |
@@ -32,13 +32,20 @@ class ConversationCreationViewModel @Inject constructor( | |||
val selectedParticipants: StateFlow<List<AutocompleteUser>> = _selectedParticipants | |||
private val roomViewState = MutableStateFlow<RoomUIState>(RoomUIState.None) | |||
|
|||
private val selectedImageUri = MutableStateFlow<Uri?>(null) | |||
val selectedImageUriState: StateFlow<Uri?> = selectedImageUri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mutable property should be prefixed with an underscore (_) and public val should be the same name without underscore:
private val _selectedImageUri = ...
val selectedImageUri StateFlow<Uri?> = _selectedImageUri
bd47cca
to
93b37ad
Compare
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
93b37ad
to
8bf9e35
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4250-talk.apk |
Resolves #4249
This PR implements:
🚧 TODO
🏁 Checklist
/backport to stable-xx.x