-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix file name of voice recording #4281
Conversation
@@ -27,6 +27,7 @@ object FileUtils { | |||
private val TAG = FileUtils::class.java.simpleName | |||
private const val RADIX: Int = 16 | |||
private const val MD5_LENGTH: Int = 32 | |||
const val FILE_MAX_LENGTH = 146 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the max length is set to 146 instead 150 because of the suffix ".mp3". This is not obvious in the FileUtils class and may lead to confusion. So i suggest to define the max length inside MediaRecorderManager and call it "VOICE_MESSAGE_PREFIX_MAX_LENGTH"
c71a2b8
to
2c177cf
Compare
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
…voice recording file name Signed-off-by: sowjanyakch <[email protected]>
2c177cf
to
de582f8
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4281-talk.apk |
Fix #1564
/
,\
and:
and replace them with a space🚧 TODO
🏁 Checklist
/backport to stable-xx.x