Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/4276/fix search availability #4306

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Oct 2, 2024

fix #4276

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Hide search feature if room is federated.
Also, for conversation list the check for federation inside isUnifiedSearchAvailable makes no sense.

Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added the 3. to review Waiting for reviews label Oct 2, 2024
@mahibi mahibi added this to the 20.1.0 milestone Oct 2, 2024
@mahibi mahibi self-assigned this Oct 2, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Oct 2, 2024

/backport to stable-20.0

Copy link

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but makes sense.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4306-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit 3073279 into master Oct 2, 2024
17 of 20 checks passed
@sowjanyakch sowjanyakch deleted the bugfix/4276/fixSearchAvailability branch October 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Display Conversation Search button in Android talk App (since app version 20.0.0)
3 participants