Always end call for everyone in one to one conversations #1629
+24
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if we should just change the default for 1:1 here. Tap -> End for all, Long press -> Option to just leave the call. I still can see occasions that I would like to leave a call without making the other leave the call as well? 🤔 |
|
Clarifying expectation:
|
Signed-off-by: Ivan Sein <[email protected]>
…tions and adjusted hang up button titles. Signed-off-by: Ivan Sein <[email protected]>
Ivansss
force-pushed
the
always-end-call-for-everyone-in-one-to-one-conversations
branch
from
ceac35d
to
ac63f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1628
Draft until we implement it in all platforms