Allow bulk task creation on paste

[t-h-e]

Solves issue #1894

See tests in tests/javascript/unit/utils/textToTask.spec.js for all possible list structures that can be pasted to create multiple tasks in one go

[t-h-e]

Here is an example:

[codecov]

Codecov Report

Merging #2273 (55438da) into master (62dbd69) will decrease coverage by 0.78%.
Report is 99 commits behind head on master.
The diff coverage is 22.64%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
- Coverage   27.33%   26.55%   -0.78%     
==========================================
  Files          60       62       +2     
  Lines        2923     3069     +146     
  Branches      744      681      -63     
==========================================
+ Hits          799      815      +16     
- Misses       2124     2254     +130     

[raimund-schluessler]

@t-h-e Thank you very much. That looks very nice. The code looks good so far and I love the fact that you even provide a test. There are some lint errors that you can mostly fix with npm run lint:fix and I have some nitpicks. I still need to test it live though.

[t-h-e]

Thanks for the comments. I configured eslint to be run by my IDE

[raimund-schluessler]

@t-h-e Thanks a lot! I have a few minor code style related comments, and will try to find the time to test the functionality later this week.

[t-h-e]

I have addressed your review comments. Let me know if there is anything else 😃

[raimund-schluessler]

Sorry that it takes me so long. My Nextcloud dev env was broken, and it took me a while to fix it. I will hopefully have a look at the weekend latest.

[t-h-e]

Hi @raimund-schluessler just wanted to check in what the status is.
Side note: I run my Nextcloud dev setup in docker. So if there is an issue with Nextcloud, I can just remove the container and create a new one.

[raimund-schluessler]

@jancborchardt Could you please add @t-h-e to nextcloud/tasks?

[raimund-schluessler]

@t-h-e Thanks a lot for the contribution! I finally had time to the PR and it seems to work really nicely. The only problem I found is this:

• Paste multiple tasks into the input field
• See the CreateMultipleTasksDialog appear
• Press Enter
  --> The app creates a single task with a the pasted tasks structure as name, instead of confirming the dialog and creating multiple tasks

It seems that the input field still has focus and then triggers a single task creation. If you could fix this, I think we could merge the PR. I think it should be possible to programmatically focus the Create Tasks button in the dialog, e.g. on mount.

[t-h-e]

It seems that the input field still has focus and then triggers a single task creation. If you could fix this, I think we could merge the PR. I think it should be possible to programmatically focus the Create Tasks button in the dialog, e.g. on mount.

Actually the focus is automatically on the first button in the dialog. The issue is, at least that is what it seems to me, that the button already reacts on keydown event. If afterwards the focus is set again to the input field in the cancel or close event, the keyup event is fired afterwards, which leads to the creation of an empty task.

As the first button seems to have the focus after showing the dialog, I prevent keydown and keyup events for that button. Not nice, but I could not find a better solution.

[t-h-e]

Actually you are right. Focusing Create Tasks button works 😄

[raimund-schluessler]

Thanks a lot, it works a lot better now.

However, whether the task input field is cleared, depends on how the modal is closed. That might be a bit unexpected.

After creating the tasks, the input is:

• cleared when clicking Close
• not cleared when clicking on the X or outside the modal

After pasting text, but before creating tasks, the input is:

• not cleared when clicking Cancel
• cleared when clicking on the X or outside the modal

I would propose that the input field is always cleared after the tasks where created, but never cleared when canceling the task creation.

[raimund-schluessler]

@jancborchardt Could you please add @t-h-e to nextcloud/tasks?

@jancborchardt Ping 🙂

[t-h-e]

I forgot a ! 🙈
See 55438da

[t-h-e]

I would propose that the input field is always cleared after the tasks where created, but never cleared when canceling the task creation.

Note that Firefox and Chrome behave differently. In Firefox it behaves now as you described. In Chrome, the pasted text is never placed in the input field.

EDIT: I have tried to change @paste.stop just to @paste, but that did not change the behaviour in either browser. If I change @paste.stop to @paste.stop.prevent, both browsers behave the same way. They then do not place the pasted text in the input. I actually prefer the Firefox behaviour that the text is in the input field. Which is nice, if the user did not intend to create multiple tasks.

[raimund-schluessler]

It works well now, I would say we can merge it.

Note that Firefox and Chrome behave differently. In Firefox it behaves now as you described. In Chrome, the pasted text is never placed in the input field.

We might be able to fix this by explicitly setting the input field value to the pasted string after canceling.

[brahimjarallah]

Here is an example:

why this feature doesn't work for me in nextcloud 27 ?

[raimund-schluessler]

Because, as I wrote in the issue you created, and as you can see in the milestone, it is unreleased. It will be released with v0.16.0.

[RayBB]

@t-h-e thanks for your hard work on this. I'm so happy to see it finally released :)

[jancborchardt]

@raimund-schluessler @t-h-e sorry for missing the ping – @t-h-e you are added to the Nextcloud org and the Tasks contributors now. :)