[Feature] Enable sorting by tags #2658
Conversation
|
Thanks for the contribution, I will have a look. Could you please already remove the added translation files? Translation is handled via Transifex, what is included manually will be overwritten at the next sync. Edit: And could you please also fix the lint errors? |
SebieF
force-pushed
the
feature/sort-by-tags
branch
from
b8ebb55
to
18fd86a
Compare
|
You are welcome and thanks for taking a look! I removed the translation files and fixed the linter errors, let me know if any additional changes are necessary :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Sorts tags in the following order (descending): (no tags) (no tags) A B A C B B D Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
It expects a string array rather than a string Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
SebieF
force-pushed
the
feature/sort-by-tags
branch
from
dd09ecb
to
93f1f60
Compare
Once applied, this PR will make it possible to sort tasks by given tags.
Tags are sorted in the following order:
I used
nvm install 20node version for building and testing. I added a unit test and ran it usingnpx vitest run. For translations, I added a german translation. If it is necessary to add all translations before, please add a comment and I will add them soon. I wanted to create the PR first such that I can get feedback if my implemented feature matches the expectations for the project :)Closes #1466.