Text processing integration

[juliushaertl]

📝 Summary

• Resolves: Integrate text processing API #4613

🚧 TODO

• Requires https://github.com/julien-nc/textprocessing_assistant
• Requires New OCS endpoint to list text processing tasks server#39680

Follow ups

• use notifications for triggering fetch instead of polling
• FAB on mobile
• How to handle markdown vs plain text
• Dismiss notifications
• Maybe later
  • merge translate to it and just move the actions to popover directly
  • Think about the making it show/hide depending on the mouse cursor (gdocs)

🖼️ Screenshots

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[cypress]

Passing run #11609 ↗︎

0

149

2

0

0

Details:

Text processing integration
Project: Text	Commit: 5ebcd8bd77
Status: Passed	Duration: 04:15 💡
Started: Aug 9, 2023 4:18 PM	Ended: Aug 9, 2023 4:22 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[jancborchardt]

Looks really great! :) The only thing I am a bit worried about is that even with the icon on the button, "Show assistant results" in the menu then is not super obvious.

• Should we permanently show "Assistant results" as an entry on the top instead?
• We could also say "Assistant results (4 new)" or have a counter bubble there for unviewed results if possible?
• Other ideas?

[nimishavijay]

Looks really nice! Super cool! Only one thing: maybe we can add a separator line before "Show assistant results" to indicate a different type of action. Other than that it looks great! :)

[juliushaertl]

Fixed:

[juliushaertl]

Looks really great! :) The only thing I am a bit worried about is that even with the icon on the button, "Show assistant results" in the menu then is not super obvious.
Should we permanently show "Assistant results" as an entry on the top instead?
We could also say "Assistant results (4 new)" or have a counter bubble there for unviewed results if possible?
Other ideas?

I think the indicator about the status already gives an idea, considering the timeline of getting this merged, I'd rather get it in and align during the demo next week if this is something we can polish next week and delay screenshot taking or keep as it is. In any case having clear mockups for any permanent display option would be appreciated then.

[max-nextcloud]

Code looks good. Did not try myself.

I think I'd personally compose the Assistent.vue out of smaller components for the Floating Menu and the Modal. But that can also happen later. I also did not check how much code reuse there is between the two. If they overlap a lot might not be worth it either.

[juliushaertl]

/compile

[juliushaertl]

/backport to stable27

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[juliushaertl]

/backport 526302d,130a4ec5fe5f24e0e27a63e459eeea22472770e5,5ebcd8bd7788afa300b2da098a88067b59eec9dc to stable27

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport