fix(TaskList): Add class name to rendered HTML #6323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/paste_task_list
branch
from
d76282c
to
d000c8f
Compare
juliushaertl
approved these changes
Sep 9, 2024
mejo-
force-pushed
the
fix/paste_task_list
branch
from
d000c8f
to
6b19642
Compare
The upstream Tiptap tasklist implementation uses data-type attributes to identify task lists and task items. We use class names instead as we depend on the markdown-it-task-lists plugin. This fixes copy & paste of task lists. Fixes: #5237 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/paste_task_list
branch
from
6b19642
to
36bfb78
Compare
|
/backport to stable30 |
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream Tiptap tasklist implementation uses data-type attributes to identify task lists and task items. We use class names instead as we depend on the markdown-it-task-lists plugin.
This fixes copy & paste of task lists.
Fixes: #5237
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)