Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deleteTasksOnCompletion to Azure Batch configuration #4114

Merged
merged 11 commits into from
Jul 25, 2023
Merged

Add deleteTasksOnCompletion to Azure Batch configuration #4114

merged 11 commits into from
Jul 25, 2023

Commits on Jul 19, 2023

  1. Add deleteTasksOnCompletion to Azure Configuration 

    Deleting Azure Tasks was checking the configuration object
deleteJobsOnCompletion which was incorrect since a task belongs to a
job. This adds the equivalent configuration for tasks which is checked
before deleting the tasks.

Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    778d0f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Revert commited Const.groovy file 

    Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    32abc3c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. minor edits 

    Signed-off-by: Ben Sherman <[email protected]>
    @bentsherman
    bentsherman committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    51bf0d9 View commit details
    Browse the repository at this point in the history

  2. Cleanup docs and comments 

    Signed-off-by: Ben Sherman <[email protected]>
    @bentsherman
    bentsherman committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    caa2366 View commit details
    Browse the repository at this point in the history

  3. Change default Azure deleteJobsOnCompletion to false 

    Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    64307dc View commit details
    Browse the repository at this point in the history

  4. Be more specific with azure.batch.terminateJobsOnCompletion docs 

    Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a86498a View commit details
    Browse the repository at this point in the history

  5. Azure config tests corrected 

    Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot
    adamrtalbot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    48c59ff View commit details
    Browse the repository at this point in the history

  6. Update docs/config.md 

    Co-authored-by: Ben Sherman <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot @bentsherman
    adamrtalbot and bentsherman authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    46a4301 View commit details
    Browse the repository at this point in the history

  7. Update docs/config.md 

    Co-authored-by: Ben Sherman <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
    @adamrtalbot @bentsherman
    adamrtalbot and bentsherman authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1e0fa0b View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Update tests and docs 

    Signed-off-by: Ben Sherman <[email protected]>
    @bentsherman
    bentsherman committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c6c9527 View commit details
    Browse the repository at this point in the history

  2. Update docs for deleteTasksOnCompletion 

    Signed-off-by: Ben Sherman <[email protected]>
    @bentsherman
    bentsherman committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e363418 View commit details
    Browse the repository at this point in the history