Document callback headers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
approved these changes
Mar 20, 2024
SPEC.md
Outdated
| A client may attach arbitrary headers to the request. | ||
|
|
||
| Headers that start with the `Nexus-Callback-` prefix are expected to be attached to the callback request when invoked by | ||
| the handler. The callback request should strip away the `Nexus-Callback-` prefix. E.g if a Start Operation request |
There was a problem hiding this comment.
nit: This is a must, not a should, right? I think we could say that the handler must strip the prefix before delivering the callback to the client.
bergundy
force-pushed
the
callback-headers
branch
from
697945e
to
22f6245
Compare
MichaelSnowden
approved these changes
Mar 20, 2024
bergundy
added a commit
to nexus-rpc/sdk-go
that referenced
this pull request
Mar 21, 2024
Exposed callback headers as defined in this recent change to the API: nexus-rpc/api#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.