Remove downstream error from predefined error types #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Jun 17, 2024
SPEC.md
Outdated
| @@ -262,7 +262,6 @@ following predefined error codes. | |||
| | `INTERNAL` | 500 | An internal error occured. | | |||
| | `NOT_IMPLEMENTED` | 501 | The server either does not recognize the request method, or it lacks the ability to fulfill the request. | | |||
| | `UNAVAILABLE` | 503 | The service is currently unavailable. | | |||
| | `DOWNSTREAM_ERROR` | 520 | Used by gateways to report that a downstream server has responded with an error. | | |||
| | `DOWNSTREAM_TIMEOUT` | 521 | Used by gateways to report that a request to a downstream server has timed out. | | |||
There was a problem hiding this comment.
Let's use 520 for the timeout then.
bergundy
reviewed
Jun 17, 2024
bergundy
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
DOWNSTREAM_ERRORfrom the list of predefined handler error typesChanged
DOWNSTREAM_TIMEOUTto520