Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v3.0.2 #97

Merged
merged 10 commits into from
Oct 12, 2024

Conversation

nf-core-bot
Copy link
Member

Version 3.0.2 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-3.0.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v3.0.2 release page.

Copy link

github-actions bot commented Oct 11, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit baf5dda

+| ✅ 206 tests passed       |+
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-11 16:28:36

Copy link

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bit more going on here than the Template update 😄
I'm not sure I'm competent enough to know if the deletion of multiqc is good.
Why did you keep the modules if you remove its use ?

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member

There is a bit more going on here than the Template update 😄 I'm not sure I'm competent enough to know if the deletion of multiqc is good. Why did you keep the modules if you remove its use ?

Total mistake from my part, I restored MultiQC

docs/output.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
tower.yml Outdated Show resolved Hide resolved
workflows/bamtofastq.nf Outdated Show resolved Hide resolved
workflows/bamtofastq.nf Outdated Show resolved Hide resolved
Copy link

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go for me !

@maxulysse maxulysse merged commit 95b46ed into dev Oct 12, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants