Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v2.13 #99

Closed
wants to merge 11 commits into from

Conversation

nf-core-bot
Copy link
Member

Version 2.13 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.13 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.13 release page.

Copy link

github-actions bot commented Feb 28, 2024

nf-core lint overall result: Failed ❌

Posted for pipeline commit df3fa93

+| ✅ 191 tests passed       |+
!| ❗   1 tests had warnings |!
-| ❌   1 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/workflows/linting.yml does not match the template

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

✅ Tests passed:

Run details

  • nf-core/tools version 2.13
  • Run at 2024-02-29 10:44:24

Copy link
Contributor

@MariekeVromman MariekeVromman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as far as I can tell :)

.github/workflows/awsfulltest.yml Outdated Show resolved Hide resolved
.github/workflows/awstest.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/download_pipeline.yml Outdated Show resolved Hide resolved
.github/workflows/linting.yml Outdated Show resolved Hide resolved
nictru and others added 5 commits February 29, 2024 11:42
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
@nictru
Copy link
Contributor

nictru commented Feb 29, 2024

@mashehu, when will the patch be release? Apparently the changes break the linting rn...

@mashehu
Copy link
Contributor

mashehu commented Feb 29, 2024

If I don't run into too many hurdles, this afternoon (CET)

@nf-core-bot
Copy link
Member Author

Version 2.13.1 of the nf-core/tools pipeline template has just been released. This pull-request is now outdated and has been closed in favour of #101

Please use #101 to merge in the new changes from the nf-core template as soon as possible.

@nictru nictru deleted the nf-core-template-merge-2.13 branch May 30, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants