Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module update: matrixfilter #159

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Module update: matrixfilter #159

merged 4 commits into from
Oct 6, 2023

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Sep 28, 2023 •
edited
Loading

This updates the matrixfilter module

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit af62ff7

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowDifferentialabundance.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-05 12:26:38

@suzannejin
Copy link

suzannejin commented Oct 4, 2023 •
edited
Loading

the rest look fine to me!

suzannejin
suzannejin approved these changes Oct 6, 2023
View reviewed changes
Copy link

@suzannejin suzannejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@WackerO
Copy link
Collaborator Author

WackerO commented Oct 6, 2023

Thanks Suzanne!

@WackerO WackerO merged commit cb913b5 into nf-core:dev Oct 6, 2023
12 checks passed
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzannejin suzannejin suzannejin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WackerO @suzannejin @pinin4fjords