Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rlog + other small fixes #164

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Rlog + other small fixes #164

merged 5 commits into from
Oct 6, 2023

Conversation

pinin4fjords
Copy link
Member

In this PR:

  • Account properly for people choosing 'rlog' rather than 'vst' for DESeq2 variance stabilisation (hadn't twigged this was broken).
  • Fix a conditional broken in Soft matrix support #136
  • Hide all the outlier analysis if we can't do it due to covariate structure.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 510fed8

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowDifferentialabundance.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-06 09:38:42

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pinin4fjords pinin4fjords merged commit 1e75341 into dev Oct 6, 2023
12 checks passed
@pinin4fjords pinin4fjords deleted the rlog_fixes branch October 6, 2023 09:55
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants