Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shinyngs, fix contrasts passed to app creation #280

Merged
merged 5 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- [[#280](https://github.com/nf-core/differentialabundance/pull/280)] - Bump shinyngs, fix contrasts passed to app creation ([@pinin4fjords](https://github.com/pinin4fjords), review by [@WackerO](https://github.com/WackerO))
- [[#274](https://github.com/nf-core/differentialabundance/pull/274)] - Fix pagination on samples table ([@pinin4fjords](https://github.com/pinin4fjords), review by [@WackerO](https://github.com/WackerO))
- [[#272](https://github.com/nf-core/differentialabundance/pull/272)] - Show >10 contrasts in report ([@pinin4fjords](https://github.com/pinin4fjords), review by [@WackerO](https://github.com/WackerO))

Expand Down
2 changes: 1 addition & 1 deletion conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ process {
((params.report_title == null) ? '' : "--title \"$params.report_title\""),
((params.report_author == null) ? '' : "--author \"$params.report_author\""),
((params.report_description == null) ? '' : "--description \"$params.report_description\""),
((params.shinyngs_guess_unlog_matrices) ? "--guess_unlog_matrices" : ''),
( (params.study_type == 'maxquant') ? "--log2_assays ''" : (((params.exploratory_log2_assays == null) ? '' : "--log2_assays \"$params.exploratory_log2_assays\"".replace('[', '').replace(']', ''))) ),
((params.shinyngs_deploy_to_shinyapps_io) ? "--deploy_app" : ''),
((params.shinyngs_shinyapps_account == null) ? '' : "--shinyapps_account \"$params.shinyngs_shinyapps_account\""),
((params.shinyngs_shinyapps_app_name == null) ? '' : "--shinyapps_name \"$params.shinyngs_shinyapps_app_name\"")
Expand Down
8 changes: 4 additions & 4 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,22 @@
},
"shinyngs/app": {
"branch": "master",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"git_sha": "91fc36585a50f9bae98cb5b3dff36ce64c83a6b4",
"installed_by": ["modules"]
},
"shinyngs/staticdifferential": {
"branch": "master",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"git_sha": "91fc36585a50f9bae98cb5b3dff36ce64c83a6b4",
"installed_by": ["modules"]
},
"shinyngs/staticexploratory": {
"branch": "master",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"git_sha": "91fc36585a50f9bae98cb5b3dff36ce64c83a6b4",
"installed_by": ["modules"]
},
"shinyngs/validatefomcomponents": {
"branch": "master",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"git_sha": "91fc36585a50f9bae98cb5b3dff36ce64c83a6b4",
"installed_by": ["modules"]
},
"untar": {
Expand Down
2 changes: 1 addition & 1 deletion modules/nf-core/shinyngs/app/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/nf-core/shinyngs/app/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions modules/nf-core/shinyngs/app/tests/main.nf.test.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/nf-core/shinyngs/staticdifferential/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/nf-core/shinyngs/staticexploratory/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/nf-core/shinyngs/staticexploratory/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/nf-core/shinyngs/validatefomcomponents/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ params {

// ShinyNGS
shinyngs_build_app = true
shinyngs_guess_unlog_matrices = true

// Note: for shinyapps deployment, in addition to setting these values,
// SHINYAPPS_TOKEN and SHINYAPPS_SECRET must be available to the
Expand Down
6 changes: 0 additions & 6 deletions nextflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -979,12 +979,6 @@
"default": "null",
"description": "The name of the app to push to in your shinyapps.io account",
"fa_icon": "fas fa-file-signature"
},
"shinyngs_guess_unlog_matrices": {
"type": "boolean",
"default": true,
"description": "Should we guess the log status of matrices and unlog for the app?",
"help_text": "In the app context, it's usually helpful if things are not in log scale, so that e.g. fold changes make some sense with respect to observed values. This flag will cause the shinyngs app-building script to make a guess based on observed values as to the log status of input matrices, and adjust the loading accordingly."
}
},
"fa_icon": "fab fa-app-store-ios"
Expand Down
4 changes: 2 additions & 2 deletions workflows/differentialabundance.nf
Original file line number Diff line number Diff line change
Expand Up @@ -584,9 +584,9 @@ workflow DIFFERENTIALABUNDANCE {
// Make a new contrasts file from the differential metas to guarantee the
// same order as the differential results

ch_app_differential = ch_differential.first().map{it[0].keySet().join(',')}
ch_app_differential = ch_differential.first().map{it[0].keySet().tail().join(',')}
.concat(
ch_differential.map{it[0].values().join(',')}
ch_differential.map{it[0].values().tail().join(',')}
)
.collectFile(name: 'contrasts.csv', newLine: true, sort: false)
.map{
Expand Down