Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 #219

Merged
merged 1,193 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
1193 commits
Select commit Hold shift + click to select a range
57fe23c
bump version
Dec 5, 2023
4b03fd7
update modules
Dec 6, 2023
e2e36c1
nextflow schema
Dec 6, 2023
60f5258
nf-core lint
Dec 6, 2023
0f74d71
eukulele biocontainer update
Dec 7, 2023
9160116
Update nextflow.config
danilodileo Dec 7, 2023
5b77bcd
Merge pull request #218 from danilodileo/release
danilodileo Dec 7, 2023
471c6ef
Update README.md
danilodileo Dec 8, 2023
dedf144
Update README.md
danilodileo Dec 8, 2023
448656c
Update modules/local/sum_kofamscan.nf
danilodileo Dec 8, 2023
174451f
Update README.md
danilodileo Dec 8, 2023
7cf45c9
Update modules/local/sum_taxonomy.nf
danilodileo Dec 8, 2023
747f29b
Update modules/local/sum_taxonomy.nf
danilodileo Dec 8, 2023
f6e0401
Update README.md
danilodileo Dec 8, 2023
49a2bf9
Merge pull request #220 from nf-core/danilodileo-patch-1
danilodileo Dec 8, 2023
05e194a
Update nextflow.config
danilodileo Dec 8, 2023
5da4ea5
Merge pull request #221 from nf-core/danilodileo-patch-2
danilodileo Dec 8, 2023
26c943e
Update nextflow_schema.json
danilodileo Dec 8, 2023
31e37dc
Merge pull request #222 from nf-core/danilodileo-patch-3
danilodileo Dec 8, 2023
309fab2
Update subworkflows/local/fastqc_trimgalore.nf
danilodileo Dec 11, 2023
ef211a0
Update subworkflows/local/fastqc_trimgalore.nf
danilodileo Dec 11, 2023
415b457
Update subworkflows/local/fastqc_trimgalore.nf
danilodileo Dec 11, 2023
45d1a09
Update subworkflows/local/eggnog.nf
danilodileo Dec 11, 2023
922e48b
changed assets/samplesheets.csv file
Dec 11, 2023
dc8c440
Merge branch 'nf-core:dev' into dev
danilodileo Dec 11, 2023
f0202ba
updated modules
Dec 11, 2023
16c105e
prettier
Dec 11, 2023
3dbc9bf
Merge pull request #223 from danilodileo/new-samplesheet-test-data
danilodileo Dec 11, 2023
f442450
correction of indentation in local subworkflows
Dec 11, 2023
d661425
changed params options from main workflow to nextflow_schema.json wit…
Dec 11, 2023
b31a55a
Merge pull request #224 from danilodileo/review-updates
danilodileo Dec 11, 2023
fbc1792
half tests are working now
Dec 18, 2023
061a571
test_kofamscan ok
Dec 18, 2023
4296532
Update ci.yml
danilodileo Dec 18, 2023
3dee58b
Merge pull request #226 from nf-core/danilodileo-patch-4
danilodileo Dec 18, 2023
db07913
Fixed config so flag and idxstats are saved
erikrikarddaniel Dec 18, 2023
70531f7
Merge pull request #225 from danilodileo/fix-ci.yml
danilodileo Dec 19, 2023
d353bf7
Update .github/workflows/ci.yml
danilodileo Dec 19, 2023
b5571c7
updated modules
Dec 19, 2023
cad287f
prettier
Dec 19, 2023
f4f3543
linting
Dec 19, 2023
458fe50
prettier
Dec 19, 2023
9f3cd30
Merge pull request #228 from erikrikarddaniel/save-flag-idsstats
danilodileo Dec 19, 2023
62868fe
fixed test
Dec 19, 2023
31823c6
save_samtools params added
Dec 19, 2023
f6bf414
nextflow schema.json
Dec 19, 2023
341a802
Merge branch 'dev' into linting-prettier
danilodileo Dec 19, 2023
b2f590c
nextflow schema.json
Dec 19, 2023
735b56a
schema.json updated
Dec 19, 2023
06b47ba
Merge branch 'linting-prettier' of ssh://github.com/Danilo2771/metatd…
Dec 19, 2023
3e9f6ab
test
Dec 19, 2023
91410c7
prettier
Dec 19, 2023
716089c
Merge pull request #227 from danilodileo/linting-prettier
danilodileo Dec 19, 2023
da5b7e1
Update modules/local/sum_kofamscan.nf
danilodileo Dec 20, 2023
b7180df
Update modules/local/sum_kofamscan.nf
danilodileo Dec 20, 2023
5e9ed00
Update modules/local/formatspades.nf
danilodileo Dec 20, 2023
f351124
Update modules/local/eukulele/search.nf
danilodileo Dec 20, 2023
da0a0e3
Update modules/local/eggnog/download.nf
danilodileo Dec 20, 2023
6f858af
Update modules/local/cat/cat_contigs.nf
danilodileo Dec 20, 2023
83d3a0d
Update conf/modules.config
danilodileo Dec 20, 2023
980f911
updated modules.config
Dec 20, 2023
48a59cb
schema build
Dec 20, 2023
2fb7be6
prettier
Dec 20, 2023
429dd95
update test.config
Dec 20, 2023
467e428
trailing whitespace
Dec 20, 2023
075d5b7
updated modules.config
Dec 20, 2023
8a3ff93
Merge pull request #230 from danilodileo/review-PR-solving-issues
danilodileo Dec 20, 2023
f8c60c1
Update test_eukulele.config
danilodileo Dec 20, 2023
01dca57
Merge pull request #231 from nf-core/danilodileo-patch-5
danilodileo Dec 20, 2023
8fcd315
Template update for nf-core/tools version 2.11
Dec 20, 2023
afbc880
template update
Dec 20, 2023
28f149f
schema build
Dec 20, 2023
063a801
Update awsfulltest.yml
danilodileo Dec 21, 2023
5dcf6bf
Update modules.config
danilodileo Dec 21, 2023
acc535b
Update modules.config
danilodileo Dec 21, 2023
395df9c
Merge pull request #233 from nf-core/danilodileo-patch-6
danilodileo Dec 21, 2023
0a5f546
Merge pull request #232 from danilodileo/template-update
danilodileo Dec 21, 2023
66deb45
Update nextflow.config
danilodileo Dec 21, 2023
2dcf776
Update nextflow.config
danilodileo Dec 21, 2023
022602a
Merge pull request #234 from nf-core/danilodileo-patch-7
danilodileo Dec 21, 2023
02978ef
Update README.md
danilodileo Dec 22, 2023
886e617
solved bug fDor module.config
Jan 3, 2024
367e3ba
Merge pull request #235 from danilodileo/bbduk-module-config-bug
danilodileo Jan 3, 2024
899c049
Update README.md
danilodileo Jan 10, 2024
28b72f5
Update conf/modules.config
danilodileo Jan 10, 2024
cb50b1e
Update conf/modules.config
danilodileo Jan 10, 2024
8a98a46
Update conf/modules.config
danilodileo Jan 10, 2024
460a0e8
Update conf/modules.config
danilodileo Jan 10, 2024
9a3a5d1
Update conf/modules.config
danilodileo Jan 10, 2024
157d0ae
Update conf/modules.config
danilodileo Jan 10, 2024
e8d8d9d
Update conf/test_kofamscan.config
danilodileo Jan 10, 2024
ad99479
add new input for protein fasta file and gff
Jan 10, 2024
f57335d
linting
Jan 10, 2024
fbe18ec
Update nextflow.config
danilodileo Jan 10, 2024
9e6c231
Update nextflow_schema.json
danilodileo Jan 10, 2024
7ff9f44
Update workflows/metatdenovo.nf
danilodileo Jan 10, 2024
0eec0dd
fix-lint-errors
Jan 11, 2024
942a826
Merge branch 'new-input-files' of https://github.com/Danilo2771/metat…
Jan 11, 2024
951c079
modules update
Jan 11, 2024
016fbbf
add exit message
Jan 11, 2024
9ff11fb
Merge pull request #236 from danilodileo/new-input-files
danilodileo Jan 11, 2024
1697a5a
eukulele v2.0.5
Jan 12, 2024
650e939
linting
Jan 12, 2024
2fcfbb9
prettier
Jan 12, 2024
5c6aed2
Merge pull request #237 from danilodileo/fix-eukulele-version
danilodileo Jan 12, 2024
61bd7bf
Update docs/output.md
danilodileo Jan 15, 2024
f5fd432
Update docs/output.md
danilodileo Jan 15, 2024
a709045
Update docs/output.md
danilodileo Jan 15, 2024
3e71122
Update docs/output.md
danilodileo Jan 15, 2024
5af9352
Update docs/output.md
danilodileo Jan 15, 2024
8a4d294
Update modules/local/eggnog/download.nf
danilodileo Jan 15, 2024
7991e8c
Update modules/local/unpigz.nf
danilodileo Jan 15, 2024
863ee34
Update subworkflows/local/fastqc_trimgalore.nf
danilodileo Jan 15, 2024
685db69
Update test_rnaspades.config
danilodileo Jan 15, 2024
de841c5
Merge pull request #239 from nf-core/danilodileo-patch-8
danilodileo Jan 15, 2024
0d8110c
Update workflows/metatdenovo.nf
danilodileo Jan 15, 2024
c2bfda7
Lowcase columns from emapper
erikrikarddaniel Jan 16, 2024
aa25a44
input_fasta channel fixed
Jan 16, 2024
b7b9e9e
Merge branch 'dev' into fix-pop-channels-when-input-protein-fasta
Jan 16, 2024
4cd25a6
Tidy up profile name from hmmrank
erikrikarddaniel Jan 16, 2024
3e3d24e
Update workflows/metatdenovo.nf
danilodileo Jan 16, 2024
d406375
Update workflows/metatdenovo.nf
danilodileo Jan 16, 2024
f72ba60
Update workflows/metatdenovo.nf
danilodileo Jan 16, 2024
4373ad8
Update workflows/metatdenovo.nf
danilodileo Jan 16, 2024
b5fda37
lint
Jan 16, 2024
d08f083
prettier
Jan 16, 2024
035cf14
Merge branch 'fix-pop-channels-when-input-protein-fasta' of ssh://git…
Jan 16, 2024
7a8dd43
Merge pull request #240 from danilodileo/fix-pop-channels-when-input-…
danilodileo Jan 16, 2024
a082f96
Merge pull request #241 from erikrikarddaniel/fix-eggnog-case-hmmrank…
erikrikarddaniel Jan 16, 2024
0d807c1
Simplify suffix handling in eukulele search module
erikrikarddaniel Jan 17, 2024
0078127
Add checkIfExists: true to fromPath() calls
erikrikarddaniel Jan 17, 2024
dc8bc0f
Prettier
erikrikarddaniel Jan 17, 2024
3ec450c
Merge pull request #242 from erikrikarddaniel/fix-eukulele-user-proteins
danilodileo Jan 17, 2024
1c8c54e
review update
Jan 17, 2024
f61f47d
version output eukulele
Jan 17, 2024
5010e57
add version eukulele
Jan 17, 2024
3d81937
eggnog print version update
Jan 17, 2024
3f13a0e
other small fix for the review
Jan 17, 2024
c8dba20
versioning prodigal and unpigz
Jan 17, 2024
76826a0
add transdecoder predict version
Jan 17, 2024
455a8a9
Rearranged channels so user_orfs gets into file names
erikrikarddaniel Jan 18, 2024
009ca6c
Corrected spelling mistake
erikrikarddaniel Jan 18, 2024
ce4c0d3
Deal better with user assembly for names
erikrikarddaniel Jan 18, 2024
ac059c4
Merge pull request #243 from erikrikarddaniel/fix-user-orfs
danilodileo Jan 18, 2024
98275ce
add version to all processes
Jan 18, 2024
760ed9f
removed unnecessary ifEmpty
Jan 18, 2024
99051e7
Fix user assembly and orfs in modules.config
erikrikarddaniel Jan 19, 2024
4ed862d
Merge pull request #244 from erikrikarddaniel/fix-config-params
danilodileo Jan 19, 2024
80d07a6
storDir to deal with downloads databases
Jan 22, 2024
81525d7
wrong name for module
Jan 22, 2024
d1da8a2
add storeDir to eggnog downlaod
Jan 22, 2024
419016b
linting
Jan 22, 2024
26d64ee
prettier
Jan 22, 2024
b9ef4dd
identation
Jan 22, 2024
41d9253
Merge branch 'dev' into fix-review
danilodileo Jan 22, 2024
411170a
wget instead curl in kofamscan_download module
Jan 22, 2024
95aca62
Merge branch 'fix-review' of ssh://github.com/Danilo2771/metatdenovo …
Jan 22, 2024
83f3fb2
Merge pull request #245 from danilodileo/fix-review
danilodileo Jan 22, 2024
42aba4d
comment in main workflow
Jan 22, 2024
610d20a
rearranged eukulele chunk
Jan 22, 2024
8586fce
removed CAT taxonomy module from the workflow as we don't use it anymore
Jan 22, 2024
a72b519
schema build
Jan 22, 2024
51ed96f
prettier
Jan 22, 2024
8fa83c1
devcontainer.jon prettier issue
Jan 22, 2024
95f3b83
removed test_cat from nextflow.config
Jan 22, 2024
7278085
removed test_cat from ci.yml
Jan 23, 2024
456bbe5
Merge pull request #246 from danilodileo/fix-how-eukulele-is-called-i…
danilodileo Jan 23, 2024
151e734
Update README.md
danilodileo Jan 23, 2024
15d40c9
Update conf/modules.config
danilodileo Jan 23, 2024
05cc258
Update conf/modules.config
danilodileo Jan 23, 2024
f04fe3d
changes
Jan 24, 2024
45881d3
Merge pull request #247 from danilodileo/review-more-updates
danilodileo Jan 24, 2024
ab7998a
add names to eukulele subworkflow
Jan 24, 2024
e41e96b
Merge branch 'dev' into review-more-updates
Jan 24, 2024
39b9a9f
Merge pull request #248 from danilodileo/review-more-updates
danilodileo Jan 25, 2024
c3c7780
sed in emapper module simplified
Jan 25, 2024
58170e4
add ch_version to all processes
Jan 25, 2024
82b6394
add new names to substitute it values
Jan 25, 2024
d986cab
added more names to values
Jan 25, 2024
253c070
Correct containers
erikrikarddaniel Jan 25, 2024
0c56521
more aesthetic fixed
Jan 26, 2024
966a364
update aesthetic subworkflows
Jan 26, 2024
58a128d
Merge pull request #250 from erikrikarddaniel/fix-kofamscan-dwnl-cont…
danilodileo Jan 26, 2024
8696cba
Merge branch 'dev' into other-review
Jan 26, 2024
75f0338
Merge pull request #251 from danilodileo/other-review
danilodileo Jan 26, 2024
e59c4fd
Update workflows/metatdenovo.nf
danilodileo Jan 30, 2024
af53b0e
Update workflows/metatdenovo.nf
danilodileo Jan 30, 2024
fb4727e
Update workflows/metatdenovo.nf
danilodileo Jan 30, 2024
f7faca4
Update modules/local/transrate.nf
danilodileo Jan 30, 2024
0df594f
Update modules/local/transrate.nf
danilodileo Jan 30, 2024
616f2e5
changes in main workflow
Jan 31, 2024
62e4d56
changed unused variable in eukulele module
Feb 1, 2024
317b54e
removed comments
Feb 2, 2024
4a2ac19
prettier
Feb 7, 2024
1867072
Merge pull request #253 from danilodileo/new-updates-for-review
danilodileo Feb 7, 2024
4b592f5
Template update for nf-core/tools version 2.12.1
Feb 7, 2024
f9920a9
template update 2.12
Feb 7, 2024
ee45fad
updated nf-core modules
Feb 7, 2024
c49fef9
prettier
Feb 7, 2024
68cc5de
trailing whitespace
Feb 7, 2024
d05f43f
new logic for eggnog_download
Feb 7, 2024
a0066e5
nextflow.config
Feb 7, 2024
b97d6f4
modules.config
Feb 7, 2024
34918de
linting
Feb 7, 2024
38d350d
schema json
Feb 7, 2024
704ee93
eggnog download module
Feb 7, 2024
09f51cf
removed external_java.jar
Feb 8, 2024
485a6e8
linting
Feb 8, 2024
fb080ee
linting
Feb 8, 2024
ca76240
linting
Feb 8, 2024
7511208
Merge pull request #255 from danilodileo/eggnog_download_logic
danilodileo Feb 8, 2024
1572c8f
template images
Feb 8, 2024
4873b01
linting
Feb 8, 2024
f3c9479
Merge pull request #254 from danilodileo/template2.12
danilodileo Feb 8, 2024
cfef28d
add documentation for EUKulele bug
Feb 8, 2024
5b5cedd
add warning signal
Feb 8, 2024
38ebc71
add warning signal
Feb 8, 2024
4d512ce
prettier
Feb 8, 2024
24c721f
Update docs/usage.md
danilodileo Feb 8, 2024
2d5b4b3
Update docs/usage.md
danilodileo Feb 8, 2024
5cc6bf6
Update usage.md
danilodileo Feb 8, 2024
f9afca4
Update docs/usage.md
danilodileo Feb 8, 2024
88cf82c
Merge pull request #257 from danilodileo/update-eukulele-doc
danilodileo Feb 8, 2024
5a66016
Reworking eggnog download a bit
erikrikarddaniel Feb 8, 2024
4dabedb
Merge branch 'dev' of https://github.com/LNUc-EEMiS/metatdenovo into dev
erikrikarddaniel Feb 8, 2024
4f5f0a6
A subdirectory for download seems needed
erikrikarddaniel Feb 8, 2024
0b3da14
Finalize eggnog download/map rework
erikrikarddaniel Feb 9, 2024
99f75ce
Remove commented line
erikrikarddaniel Feb 9, 2024
54cb246
Merge pull request #258 from erikrikarddaniel/fix-eggnog-download
erikrikarddaniel Feb 9, 2024
4b66191
collect log prokka in a proper way
Feb 12, 2024
b045877
Merge pull request #259 from danilodileo/fix-prokka-log-bug
danilodileo Feb 12, 2024
494648b
removed param eggnog_dbpath from subworkflow
Feb 13, 2024
9f1c06c
explicit values for EGGNOG_DOWNLOAD output
Feb 13, 2024
4a525b2
Merge pull request #260 from danilodileo/remove-dbpath-from-eggnog-su…
danilodileo Feb 13, 2024
94bc66c
Template update for nf-core/tools version 2.12.1
Feb 14, 2024
53e4c69
resolved conflicts
Feb 14, 2024
cbc6a20
forgot conflict
Feb 14, 2024
17f027f
modules update
Feb 14, 2024
b0f6f93
added images from template
Feb 14, 2024
d5c5f9e
Merge pull request #261 from danilodileo/test-solving-lint-issue
danilodileo Feb 14, 2024
0d09c15
Update README.md
danilodileo Feb 15, 2024
38ca12f
Update README.md
danilodileo Feb 15, 2024
7e5dc4c
Update conf/modules.config
danilodileo Feb 15, 2024
5574262
Update docs/usage.md
danilodileo Feb 15, 2024
ee41e16
Update docs/usage.md
danilodileo Feb 15, 2024
92b7058
Update docs/usage.md
danilodileo Feb 15, 2024
4263795
Update workflows/metatdenovo.nf
danilodileo Feb 15, 2024
4a0e7b3
Update docs/usage.md
danilodileo Feb 15, 2024
b5edbf2
version missing
Feb 15, 2024
3418d1f
Merge pull request #262 from danilodileo/few-more-updates-for-review
danilodileo Feb 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/opt/conda/bin/python",
"python.linting.enabled": true,
"python.linting.pylintEnabled": true,
"python.formatting.autopep8Path": "/opt/conda/bin/autopep8",
"python.formatting.yapfPath": "/opt/conda/bin/yapf",
"python.linting.flake8Path": "/opt/conda/bin/flake8",
"python.linting.pycodestylePath": "/opt/conda/bin/pycodestyle",
"python.linting.pydocstylePath": "/opt/conda/bin/pydocstyle",
"python.linting.pylintPath": "/opt/conda/bin/pylint"
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
}
}
}
13 changes: 9 additions & 4 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,9 @@ trim_trailing_whitespace = true
indent_size = 4
indent_style = space

[*.{yml,yaml}]
[*.{md,yml,yaml,html,css,scss,js}]
indent_size = 2

[*.json]
insert_final_newline = unset

# These files are edited and tested upstream in nf-core/modules
[/modules/nf-core/**]
charset = unset
Expand All @@ -25,3 +22,11 @@ indent_size = unset

[/assets/email*]
indent_size = unset

# ignore Readme
[README.md]
indent_style = unset

# ignore python
[*.{py}]
indent_style = unset
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
*.config linguist-language=nextflow
*.nf.test linguist-language=nextflow
modules/nf-core/** linguist-generated
subworkflows/nf-core/** linguist-generated
65 changes: 30 additions & 35 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@ Please use the pre-filled template to save time.
However, don't be put off by this template - other more general issues and suggestions are welcome!
Contributions to the code are even more welcome ;)

> If you need help using or modifying nf-core/metatdenovo then the best place to ask is on the nf-core Slack [#metatdenovo](https://nfcore.slack.com/channels/metatdenovo) channel ([join our Slack here](https://nf-co.re/join/slack)).
:::info
If you need help using or modifying nf-core/metatdenovo then the best place to ask is on the nf-core Slack [#metatdenovo](https://nfcore.slack.com/channels/metatdenovo) channel ([join our Slack here](https://nf-co.re/join/slack)).
:::

## Contribution workflow

If you'd like to write some code for nf-core/metatdenovo, the standard workflow is as follows:

1. Check that there isn't already an issue about your idea in the [nf-core/metatdenovo issues](https://github.com/nf-core/metatdenovo/issues) to avoid duplicating work
* If there isn't one already, please create one so that others know you're working on this
1. Check that there isn't already an issue about your idea in the [nf-core/metatdenovo issues](https://github.com/nf-core/metatdenovo/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/metatdenovo repository](https://github.com/nf-core/metatdenovo) to your GitHub account
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
4. Use `nf-core schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
Expand All @@ -26,6 +27,9 @@ If you're not used to this workflow with git, you can start with some [docs from

## Tests

You can optionally test your changes by running the pipeline locally. Then it is recommended to use the `debug` profile to
receive warnings about process selectors and other debug info. Example: `nextflow run . -profile debug,test,docker --outdir <OUTDIR>`.

When you create a pull request with changes, [GitHub Actions](https://github.com/features/actions) will run automatic tests.
Typically, pull-requests are only fully reviewed when these tests are passing, though of course we can help out before then.

Expand All @@ -49,9 +53,9 @@ These tests are run both with the latest available version of `Nextflow` and als

:warning: Only in the unlikely and regretful event of a release happening with a bug.

* On your own fork, make a new branch `patch` based on `upstream/master`.
* Fix the bug, and bump version (X.Y.Z+1).
* A PR should be made on `master` from patch to directly this particular bug.
- On your own fork, make a new branch `patch` based on `upstream/master`.
- Fix the bug, and bump version (X.Y.Z+1).
- A PR should be made on `master` from patch to directly this particular bug.

## Getting help

Expand All @@ -68,16 +72,13 @@ If you wish to contribute a new step, please use the following coding standards:
1. Define the corresponding input channel into your new process from the expected previous process channel
2. Write the process block (see below).
3. Define the output channel if needed (see below).
4. Add any new flags/options to `nextflow.config` with a default (see below).
5. Add any new flags/options to `nextflow_schema.json` with help text (with `nf-core schema build`).
6. Add any new flags/options to the help message (for integer/text parameters, print to help the corresponding `nextflow.config` parameter).
7. Add sanity checks for all relevant parameters.
8. Add any new software to the `scrape_software_versions.py` script in `bin/` and the version command to the `scrape_software_versions` process in `main.nf`.
9. Do local tests that the new code works properly and as expected.
10. Add a new test command in `.github/workflow/ci.yml`.
11. If applicable add a [MultiQC](https://https://multiqc.info/) module.
12. Update MultiQC config `assets/multiqc_config.yaml` so relevant suffixes, name clean up, General Statistics Table column order, and module figures are in the right order.
13. Optional: Add any descriptions of MultiQC report sections and output files to `docs/output.md`.
4. Add any new parameters to `nextflow.config` with a default (see below).
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core schema build` tool).
6. Add sanity checks and validation for all relevant parameters.
7. Perform local tests to validate that the new code works as expected.
8. If applicable, add a new test command in `.github/workflow/ci.yml`.
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.

### Default values

Expand All @@ -95,34 +96,28 @@ The process resources can be passed on to the tool dynamically within the proces

Please use the following naming schemes, to make it easy to understand what is going where.

* initial process channel: `ch_output_from_<process>`
* intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`
- initial process channel: `ch_output_from_<process>`
- intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`

### Nextflow version bumping

If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core bump-version --nextflow . [min-nf-version]`

### Software version reporting

If you add a new tool to the pipeline, please ensure you add the information of the tool to the `get_software_version` process.

Add to the script block of the process, something like the following:
### Images and figures

```bash
<YOUR_TOOL> --version &> v_<YOUR_TOOL>.txt 2>&1 || true
```
For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).

or
## GitHub Codespaces

```bash
<YOUR_TOOL> --help | head -n 1 &> v_<YOUR_TOOL>.txt 2>&1 || true
```
This repo includes a devcontainer configuration which will create a GitHub Codespaces for Nextflow development! This is an online developer environment that runs in your browser, complete with VSCode and a terminal.

You then need to edit the script `bin/scrape_software_versions.py` to:
To get started:

1. Add a Python regex for your tool's `--version` output (as in stored in the `v_<YOUR_TOOL>.txt` file), to ensure the version is reported as a `v` and the version number e.g. `v2.1.1`
2. Add a HTML entry to the `OrderedDict` for formatting in MultiQC.
- Open the repo in [Codespaces](https://github.com/nf-core/metatdenovo/codespaces)
- Tools installed
- nf-core
- Nextflow

### Images and figures
Devcontainer specs:

For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).
- [DevContainer config](.devcontainer/devcontainer.json)
63 changes: 0 additions & 63 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Bug report
description: Report something that is broken or incorrect
labels: bug
body:
- type: markdown
attributes:
value: |
Before you post this issue, please check the documentation:

- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
- [nf-core/metatdenovo pipeline documentation](https://nf-co.re/metatdenovo/usage)

- type: textarea
id: description
attributes:
label: Description of the bug
description: A clear and concise description of what the bug is.
validations:
required: true

- type: textarea
id: command_used
attributes:
label: Command used and terminal output
description: Steps to reproduce the behaviour. Please paste the command you used to launch the pipeline and the output from your terminal.
render: console
placeholder: |
$ nextflow run ...

Some output where something broke

- type: textarea
id: files
attributes:
label: Relevant files
description: |
Please drag and drop the relevant files here. Create a `.zip` archive if the extension is not allowed.
Your verbose log file `.nextflow.log` is often useful _(this is a hidden file in the directory where you launched the pipeline)_ as well as custom Nextflow configuration files.

- type: textarea
id: system
attributes:
label: System information
description: |
* Nextflow version _(eg. 23.04.0)_
* Hardware _(eg. HPC, Desktop, Cloud)_
* Executor _(eg. slurm, local, awsbatch)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
* Version of nf-core/metatdenovo _(eg. 1.1, 1.5, 1.8.2)_
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
blank_issues_enabled: false
contact_links:
- name: Join nf-core
url: https://nf-co.re/join
Expand Down
32 changes: 0 additions & 32 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Feature request
description: Suggest an idea for the nf-core/metatdenovo pipeline
labels: enhancement
body:
- type: textarea
id: description
attributes:
label: Description of feature
description: Please describe your suggestion for a new feature. It might help to describe a problem or use case, plus any alternatives that you have considered.
validations:
required: true
8 changes: 4 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ Remember that PRs should be made against the dev branch, unless you're preparing

Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/metatdenovo/tree/master/.github/CONTRIBUTING.md)
-->
<!-- markdownlint-disable ul-indent -->

## PR checklist

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/metatdenovo/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/metatdenovo _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/metatdenovo/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/metatdenovo _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
Expand Down
18 changes: 10 additions & 8 deletions .github/workflows/awsfulltest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,23 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Launch workflow via tower
uses: nf-core/tower-action@master
# TODO nf-core: You can customise AWS full pipeline tests as required
# Add full size test data (but still relatively small datasets for few samples)
# on the `test_full.config` test runs with only one set of parameters

uses: seqeralabs/action-tower-launch@v2
with:
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
bearer_token: ${{ secrets.TOWER_BEARER_TOKEN }}
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
compute_env: ${{ secrets.TOWER_COMPUTE_ENV }}
pipeline: ${{ github.repository }}
revision: ${{ github.sha }}
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/metatdenovo/work-${{ github.sha }}
parameters: |
{
"hook_url": "${{ secrets.MEGATESTS_ALERTS_SLACK_HOOK_URL }}",
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/metatdenovo/results-${{ github.sha }}"
}
profiles: '[ "test_full", "aws_tower" ]'
profiles: test_full

- uses: actions/upload-artifact@v4
with:
name: Tower debug log file
path: |
tower_action_*.log
tower_action_*.json
Loading
Loading