Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bbnorm minid #282

Merged
merged 6 commits into from
Apr 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v1.1.0 - [date]
## v1.1.0dev - [date]

### `Added`

- [#280](<[https://github.com/nf-core/metatdenovo/issues/280](https://github.com/nf-core/metatdenovo/issues/280)>) - Added minid option to bbmap_align module. Now the threshold for mapping a read to a contig is an identity of 0.9. The previous version of nf-core/metatdenovo used the default for BBMap, 0.76. This version might hence give slightly different results than the previous.
- [#271](<[https://github.com/nf-core/metatdenovo/issues/271](https://github.com/nf-core/metatdenovo/issues/271)>) - Added flavor to SPADES modules

### `Changed`
Expand Down
4 changes: 2 additions & 2 deletions assets/multiqc_config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
report_comment: >
This report has been generated by the <a href="https://github.com/nf-core/metatdenovo/releases/tag/1.0.1" target="_blank">nf-core/metatdenovo</a>
This report has been generated by the <a href="https://github.com/nf-core/metatdenovo/tree/dev" target="_blank">nf-core/metatdenovo</a>
analysis pipeline. For information about how to interpret these results, please see the
<a href="https://nf-co.re/metatdenovo/1.0.1/docs/output" target="_blank">documentation</a>.
<a href="https://nf-co.re/metatdenovo/dev/docs/output" target="_blank">documentation</a>.

report_section_order:
"nf-core-metatdenovo-methods-description":
Expand Down
2 changes: 1 addition & 1 deletion conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ process {
}

withName: BBMAP_ALIGN {
ext.args = "trimreaddescriptions=t pigz=t"
ext.args = { "trimreaddescriptions=t pigz=t minid=${params.bbmap_minid}" }
publishDir = [
[
path: { "${params.outdir}/bbmap/bam" },
Expand Down
3 changes: 2 additions & 1 deletion nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ params {
// Mapping options
save_samtools = false
save_bam = false
bbmap_minid = 0.9

// orf caller options
orf_caller = 'prodigal'
Expand Down Expand Up @@ -290,7 +291,7 @@ manifest {
description = """Assembly and annotation of metatranscriptomic data, both prokaryotic and eukaryotic"""
mainScript = 'main.nf'
nextflowVersion = '!>=23.04.0'
version = '1.0.1'
version = '1.1.0dev'
doi = ''
}

Expand Down
7 changes: 7 additions & 0 deletions nextflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,13 @@
"save_samtools": {
"type": "boolean",
"description": "Save the output from samtools"
},
"bbmap_minid": {
"type": "number",
"default": 0.9,
"fa_icon": "fas fa-address-card",
"description": "Minimum identity needed to assign read to a contig",
"help_text": ""
}
},
"fa_icon": "fas fa-filter"
Expand Down
Loading