Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double check migrated tests are consistent #4175

Open
edmundmiller opened this issue Oct 19, 2023 · 1 comment · Fixed by #4521
Open

Double check migrated tests are consistent #4175

edmundmiller opened this issue Oct 19, 2023 · 1 comment · Fixed by #4521
Assignees
@edmundmiller
Labels
nf-test

Comments

@edmundmiller
Copy link
Contributor

edmundmiller commented Oct 19, 2023 •
edited
Loading

I just realized by not deleting the pytest-workflow tests in the PRs we probably didn't check that all of the tests were 1-to-1... At least I didn't on the one's I reviewed 😬

@nf-core/nf-test
@adamrtalbot
Copy link
Contributor

We can also do a checkup and tidy:

  • pytest has been removed
  • assertAll
  • tags in a consistent order
  • snaps contain the right files.

@edmundmiller edmundmiller changed the title Double check migrated tests a consistant Double check migrated tests are consistent Dec 6, 2023
@edmundmiller edmundmiller self-assigned this Dec 6, 2023
@edmundmiller edmundmiller linked a pull request Dec 6, 2023 that will close this issue
Remove pytest-workflow tests for modules covered by nf-test #4521
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edmundmiller edmundmiller

Labels
nf-test
Projects
Hackathon: May 2024
Status: No status
Hackathon: November 2023
Status: To do
nf-test Migration
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pytest-workflow tests for modules covered by nf-test nf-core/modules
2 participants
@adamrtalbot @edmundmiller