Remove pytest-workflow tests for modules covered by nf-test #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
force-pushed
the
remove-duplicate-tests
branch
from
938e4bd
to
80b01c7
Compare
edmundmiller
requested review from
a team,
adamrtalbot and
sateeshperi
and removed request for
a team
edmundmiller
requested review from
drpatelh,
grst,
ewels and
FelixKrueger
as code owners
grst
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Looks good!
Btw, as the pytests are being removed, did you come up with a solution to substitute the valid version yaml checker in nf-test?
|
I hadn't but I think we'll be able to make something simple soon because of #4517 |
|
Still thinking about this 😆 That was an oversight on the migration, but I think we should focus on migrating to the topic channels instead. Or wait will we use the yml files still, we'll just pull them in with the topic channel? 🤔 I think that's what will end up happening, adding it to the tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff that we didn't cut out during the Barcelona Hackathon because the linting wasn't up to date yet.
If anyone wants to volunteer to go through and make sure all of the tests had equivalent coverage, have at it!