Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try alternative strategy for extracting tags #4928

Merged
merged 88 commits into from
May 1, 2024

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Feb 15, 2024

This PR introduces the new strategy pioneered by @CarsonJM to the nf-core/modules repo.

Steps:

  1. adamrtalbot/detect-nf-changes to identify the changes between the base and incoming branch and return them as tests to be ran.
  2. Split into module and subworkflow channel (heh x2)
  3. Combine modules channel from pytest and nf-test and run linting as a matrix nf-core modules lint ${module}
  4. Combine subworkflows channel from pytest and nf-test and run linting as a matrix nf-core subworkflows lint ${module}
  5. Combine modules and subworkflows channel and run pytest as a matrix pytest --tag ${module}
  6. Combine modules and subworkflows channel from nf-test-changes and run nf-test as a matrix nf-test test ${path}

@adamrtalbot adamrtalbot marked this pull request as ready for review April 5, 2024 16:19
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@adamrtalbot adamrtalbot added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@adamrtalbot adamrtalbot enabled auto-merge May 1, 2024 09:24
@adamrtalbot adamrtalbot added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@adamrtalbot adamrtalbot added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@adamrtalbot adamrtalbot enabled auto-merge May 1, 2024 09:59
@adamrtalbot adamrtalbot added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@adamrtalbot adamrtalbot added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@adamrtalbot adamrtalbot added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@adamrtalbot adamrtalbot added this pull request to the merge queue May 1, 2024
Merged via the queue into nf-core:master with commit ac58a02 May 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.