Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore samtools modules version bump #6685

Merged
merged 3 commits into from
Sep 24, 2024
Merged

restore samtools modules version bump #6685

merged 3 commits into from
Sep 24, 2024

Conversation

maxulysse
Copy link
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@maxulysse
Copy link
Member Author

It should restore some efforts made in #6648 that were reverted by #6674

@maxulysse
Copy link
Member Author

Just 14 failures, I'm impressed

@maxulysse maxulysse mentioned this pull request Sep 24, 2024
Open
@maxulysse maxulysse merged commit b13f07b into nf-core:master Sep 24, 2024
161 of 163 checks passed
@maxulysse
Copy link
Member Author

Just 14 failures, I'm impressed

only 1 left on retry, so force-merging

@maxulysse maxulysse deleted the samtools_groundhog_bump branch September 24, 2024 09:49
@apeltzer
Copy link
Member

Just 14 failures, I'm impressed

only 1 left on retry, so force-merging

🤠

herpov pushed a commit to herpov/modules that referenced this pull request Oct 2, 2024
@maxulysse
restore samtools modules version bump (nf-core#6685)
a592b81 
* restore samtools modules version bump

* add htslib

* same environment.yml file for each samtools modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthdsm matthdsm matthdsm approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

@JoseEspinosa JoseEspinosa Awaiting requested review from JoseEspinosa

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

@priyanka-surana priyanka-surana Awaiting requested review from priyanka-surana

@ramprasadn ramprasadn Awaiting requested review from ramprasadn

@LouisLeNezet LouisLeNezet Awaiting requested review from LouisLeNezet

@yuukiiwa yuukiiwa Awaiting requested review from yuukiiwa

@SPPearce SPPearce Awaiting requested review from SPPearce

@suzannejin suzannejin Awaiting requested review from suzannejin

@muffato muffato Awaiting requested review from muffato

@louperelo louperelo Awaiting requested review from louperelo

@nevinwu nevinwu Awaiting requested review from nevinwu

@lescai lescai Awaiting requested review from lescai

@JackCurragh JackCurragh Awaiting requested review from JackCurragh

@bjohnnyd bjohnnyd Awaiting requested review from bjohnnyd

@phue phue Awaiting requested review from phue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @apeltzer @matthdsm