-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5127 new module xenium ranger #6826
base: master
Are you sure you want to change the base?
5127 new module xenium ranger #6826
Conversation
…uite changes,readme update
…ule for xeniumranger rename
…ule for xeniumranger rename
…ersameesh24/modules into 5127-new-module-xenium-ranger
…ersameesh24/modules into 5127-new-module-xenium-ranger
5127 new module xenium ranger
val(meta) | ||
path(xenium_bundle) | ||
val(expansion_distance) | ||
path(coordinate_transform) | ||
path(nuclei) | ||
path(cells) | ||
path(transcript_assignment) | ||
path(viz_polygons) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sample specific data should go in the same tuple as meta
.
Reference data should either go in one tuple with it's own meta
or in separate channels per datatype, again each with it's own meta
example: https://github.com/nf-core/modules/blob/master/modules/nf-core/snapaligner/align/main.nf#L10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Changed -> Tested -> Updated PR ✌🏻
val(meta) | ||
path(xenium_bundle) | ||
val(expansion_distance) | ||
path(coordinate_transform) | ||
path(nuclei) | ||
path(cells) | ||
path(transcript_assignment) | ||
path(viz_polygons) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path(viz_polygons) | ||
|
||
output: | ||
tuple val(meta), path("**/outs/**"), emit: outs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the tool output? different file formats should also have different output channels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Matthias, the output for xeniumranger modules is reupdated in the input files just like other 10x tools, multiple files are updated for every run and hence we do not have a dedicated channel for the outputs
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda