Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parabricks/applybqsr version updated and tests migrated to nf-test #6881

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

gitanoqevaporelmundoentero
Copy link
Contributor

@gitanoqevaporelmundoentero gitanoqevaporelmundoentero commented Oct 29, 2024

Tools applybqsr is updated to latest version (4.3.2-1) and tests were migrated to new convention (from pytest to nf-test).

PR checklist

Closes #6861

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

.github/workflows/test.yml Show resolved Hide resolved
@famosab
Copy link
Contributor

famosab commented Oct 29, 2024

We need to change the way the GPUs are accessed in the main.nf file. Maybe we can do that here aswell.

so the line
--num-gpus $task.accelerator.request \\

needs to be
$num_gpus \\

and add this above the script block
def num_gpus = task.accelerator ? "--num-gpus $task.accelerator.request" : ''


And we need to add below the label expression on the top of the file
label 'process_gpu'

@gitanoqevaporelmundoentero gitanoqevaporelmundoentero changed the title parabricks/applybqsr version updated and tests migrated to pytest parabricks/applybqsr version updated and tests migrated to nf-test Oct 29, 2024
@famosab famosab self-assigned this Oct 30, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a config ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was in the old tests folder from the pytest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update module: parabricks/applybqsr
3 participants