Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: scvitools/solo single-cell doublet detection #6891

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

LeonHafner
Copy link
Contributor

@LeonHafner LeonHafner commented Oct 29, 2024

PR checklist

  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label

@LeonHafner LeonHafner added new module Adding a new module draft labels Oct 29, 2024
@LeonHafner
Copy link
Contributor Author

@nf-core-bot fix linting

@LeonHafner
Copy link
Contributor Author

Module is producing inconsistent hashes for the output anndata object across two nf-test runs.

Copy link
Contributor

@nictru nictru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideas for removing sources of randomness

@nictru
Copy link
Contributor

nictru commented Oct 30, 2024

Things left to be done:

  • Remove unnecessary seeds
  • Update scvi-tools version and remove batch stuff

@LeonHafner LeonHafner self-assigned this Oct 31, 2024
@LeonHafner LeonHafner marked this pull request as ready for review October 31, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft new module Adding a new module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants