Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor typos #7177

Merged
merged 14 commits into from
Jan 8, 2025
Merged

Fix minor typos #7177

merged 14 commits into from
Jan 8, 2025

Conversation

mribeirodantas
Copy link
Member

@mribeirodantas mribeirodantas commented Dec 8, 2024 •
edited
Loading

This PR fixes multiple typos in several different modules.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mribeirodantas mribeirodantas requested a review from ewels December 8, 2024 04:19
@mribeirodantas mribeirodantas self-assigned this Dec 8, 2024
edmundmiller
edmundmiller previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see anything that wasn't a comment or doc, so it shouldn't break anything 😬

Ran nf-core modules lint locally and nothing seemed to be out of place.

modules/nf-core/popscle/freemuxlet/meta.yml Outdated Show resolved Hide resolved
@mribeirodantas
Copy link
Member Author

Good to merge? @maxulysse @edmundmiller

@maxulysse
Copy link
Member

Ok for me

@maxulysse
Copy link
Member

@SPPearce let's just merge this one and be done with it

SPPearce
SPPearce requested changes Jan 8, 2025
View reviewed changes
modules/nf-core/ampcombi/tests/main.nf.test.snap Outdated Show resolved Hide resolved
modules/nf-core/iqtree/tests/main.nf.test.snap Outdated Show resolved Hide resolved
modules/nf-core/popscle/freemuxlet/tests/main.nf.test Outdated Show resolved Hide resolved
tests/modules/nf-core/parabricks/mutectcaller/main.nf Outdated Show resolved Hide resolved
modules/nf-core/arriba/download/tests/main.nf.test.snap Outdated Show resolved Hide resolved
SPPearce
SPPearce approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm happy to force merge this in now.

@SPPearce SPPearce requested a review from a team as a code owner January 8, 2025 13:01
@maxulysse maxulysse merged commit 0e9cb40 into master Jan 8, 2025
124 of 183 checks passed
@maxulysse maxulysse deleted the fix_typos branch January 8, 2025 14:39
fellen31 pushed a commit to fellen31/modules that referenced this pull request Jan 10, 2025
@mribeirodantas @edmundmiller
@SPPearce @maxulysse @fellen31
Fix minor typos (nf-core#7177)
1254968 
* Fix minor typos

* Uppercase f in MAF

* Update modules/nf-core/popscle/freemuxlet/meta.yml

Co-authored-by: Edmund Miller <[email protected]>

* Update snapshots

* Remove parabricks pytest

* Reset iqtree tool typo

* Update modules/nf-core/cat/fastq/tests/main.nf.test

* Remove ivar/consensus from pytest

* Move gatk4/asereadcounter tests into subfolder

* Remove empty environment and unused variables from coreograph

---------

Co-authored-by: Edmund Miller <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse left review comments

@SPPearce SPPearce SPPearce approved these changes

@edmundmiller edmundmiller edmundmiller left review comments

@ewels ewels Awaiting requested review from ewels

Assignees

@mribeirodantas mribeirodantas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mribeirodantas @maxulysse @edmundmiller @SPPearce