Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stub section and updated test #7257

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

MarieLataretu
Copy link
Contributor

Description

This PR adds a stub section to the module (which is somehow missing from #6219) and updates the test snapshot.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@MarieLataretu
Copy link
Contributor Author

gitpod prove for docker test:
image

@@ -35,4 +35,17 @@ process BCFTOOLS_CONSENSUS {
bcftools: \$(bcftools --version 2>&1 | head -n1 | sed 's/^.*bcftools //; s/ .*\$//')
END_VERSIONS
"""

stub:
def args = task.ext.args ?: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def args = task.ext.args ?: ''

stub:
def args = task.ext.args ?: ''
def prefix = task.ext.prefix ?: "${meta.id}"
def masking = mask ? "-m $mask" : ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def masking = mask ? "-m $mask" : ""

@SPPearce SPPearce added this pull request to the merge queue Jan 8, 2025
Merged via the queue into nf-core:master with commit 2efa3f8 Jan 8, 2025
27 checks passed
@MarieLataretu MarieLataretu deleted the add-stub-bcftools-bcftools branch January 8, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants