Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump v1.1.0 #157

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Bump v1.1.0 #157

merged 5 commits into from
Jun 3, 2024

Conversation

JoseEspinosa
Copy link
Member

Bump v1.1.0 for preparing pipeline release.

PR checklist

  • This comment contains a description of changes (with reason).
  • CHANGELOG.md is updated.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2bec617

+| ✅ 194 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  10 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • nextflow_config - Config manifest.version should end in dev: 1.1.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-01 06:49:23

FriederikeHanssen
FriederikeHanssen reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no bump in the mutliqc assets file?

@JoseEspinosa
Copy link
Member Author

JoseEspinosa commented Jun 1, 2024 •
edited
Loading

no bump in the mutliqc assets file?

Good spot! forgot to commit it 🤦

@JoseEspinosa JoseEspinosa merged commit 4308842 into nf-core:dev Jun 3, 2024
10 checks passed
@JoseEspinosa JoseEspinosa deleted the bump_v1.1.0 branch June 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseEspinosa @mirpedrol @FriederikeHanssen