Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create 2 different parameters for Colabfold and ESMfold number of recycles #166

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Create 2 different parameters for Colabfold and ESMfold number of recycles #166

merged 5 commits into from
Jun 21, 2024

Conversation

JoseEspinosa
Copy link
Member

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @JoseEspinosa,

It looks like this pull-request is has been made against the JoseEspinosa/nf-core-proteinfold master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the JoseEspinosa/nf-core-proteinfold dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@JoseEspinosa JoseEspinosa changed the title Fixes Create 2 different parameters for Colabfold and ESMfold number of recycles Jun 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e30e250

+| ✅ 194 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  10 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • nextflow_config - Config manifest.version should end in dev: 1.1.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-21 09:57:36

@JoseEspinosa JoseEspinosa changed the base branch from master to dev June 21, 2024 09:59
luisas
luisas approved these changes Jun 21, 2024
View reviewed changes
docs/usage.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as a general question - why per default we have different number of recycles in esmfold and colabfold? it's their default?

@JoseEspinosa JoseEspinosa merged commit 564e06a into nf-core:dev Jun 21, 2024
17 of 18 checks passed
@JoseEspinosa JoseEspinosa mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisas luisas luisas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mention to the AWS Open Data Sponsorship Program in readme and update licenses in s3
2 participants
@JoseEspinosa @luisas