Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release prep v1.1.0 #376

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Release prep v1.1.0 #376

merged 2 commits into from
Jul 17, 2023

Conversation

ramprasadn
Copy link
Collaborator

@ramprasadn ramprasadn commented Jul 17, 2023 •
edited
Loading

PR checklist

This PR addresses warning from nf-core lint and bumps version for the next release.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 253928f

+| ✅ 153 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.1.0
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-17 11:25:38

@ramprasadn ramprasadn marked this pull request as ready for review July 17, 2023 11:27
@ramprasadn ramprasadn changed the title Release prep Release prep v1.1.0 Jul 17, 2023
sima-r
sima-r approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@sima-r sima-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not run it though.

@ramprasadn
Copy link
Collaborator Author

Thanks for the review, @sima-r

@ramprasadn ramprasadn merged commit 3d42ae9 into nf-core:dev Jul 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sima-r sima-r sima-r approved these changes

@jemten jemten Awaiting requested review from jemten

@Lucpen Lucpen Awaiting requested review from Lucpen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramprasadn @sima-r