Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace local version of sentieon-locuscollector and sentieon-dedup #401

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Replace local version of sentieon-locuscollector and sentieon-dedup #401

merged 5 commits into from
Aug 14, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Aug 14, 2023 •
edited
Loading

Replace local version of sentieon-locuscollector and sentieon-dedup with nf-core versions

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@asp8200 asp8200 changed the title Replace local version of sentieon-locuscollector and sentieon-dedup w… Replace local version of sentieon-locuscollector and sentieon-dedup Aug 14, 2023
@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5e7fce7

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-14 14:35:25

@asp8200 asp8200 marked this pull request as ready for review August 14, 2023 14:33
ramprasadn
ramprasadn approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@ramprasadn ramprasadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏻

@asp8200 asp8200 merged commit 0aefef7 into dev Aug 14, 2023
8 checks passed
@asp8200 asp8200 deleted the update_sentieon_dedup branch August 14, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramprasadn ramprasadn ramprasadn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asp8200 @ramprasadn