Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid misleading error messages concerning sample-sheets #1629

Open
asp8200 opened this issue Aug 26, 2024 · 7 comments
Open

Avoid misleading error messages concerning sample-sheets #1629

asp8200 opened this issue Aug 26, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@asp8200
Copy link
Contributor

asp8200 commented Aug 26, 2024

Description of the bug

This bug has been around for a while now. When Sarek encounters an error is will often issue the correct error message along with a couple of wrong error messages. The wrong error messages are related to the sample-sheets.

Here is an example where Sarek v3.4.3 was given an incorrect path to the VEP-cache, and Sarek gave the following error msg:

The sample-sheet only contains tumor-samples, but the following tools, which were requested by the option "tools", expect at least one normal-sample : ascat
The sample-sheet only contains normal-samples, but the following tools, which were requested with "--tools", expect at least one tumor-sample : ascat, controlfreec, mutect2
Path provided with VEP cache is invalid.
Make sure there is a directory named homo_sapiens/111_GRCh38 in /ngc/shared/nf_tools/references/vep_cache./nPlease refer to https://nf-co.re/sarek/docs/usage/#how-to-customise-snpeff-and-vep-annotation for more information.

The error messages concerning the sample-sheet are wrong and shouldn't be issued in this scenario. (The error message concerning the VEP-cache is fine.)

The error isn't caused by nf-validation, but by code in Sarek:

error('The sample-sheet only contains tumor-samples, but the following tools, which were requested by the option "tools", expect at least one normal-sample : ' + requested_tools_requiring_normal_samples.join(", "))

error("Path provided with VEP cache is invalid.\nMake sure there is a directory named ${vep_cache_dir} in ${vep_cache}./n${help_message}")

Command used and terminal output

No response

Relevant files

No response

System information

No response

@asp8200 asp8200 added the bug Something isn't working label Aug 26, 2024
@dansteiert
Copy link

dansteiert commented Aug 30, 2024

I faced a similar issue.
When looking into the log, I found that something else caused this error message.
(Use of a custom genome and missing of additional inputs).

But the error message is misleading and lead me to double and tripple check my sample sheets

@asp8200
Copy link
Contributor Author

asp8200 commented Aug 30, 2024

I faced a similar issue. When looking into the log, I found that something else caused this error message. (Use of a custom genome and missing of additional inputs).

But the error message is misleading and lead me to double and tripple check my sample sheets

Thanks for reporting that, @dansteiert

@TILccit
Copy link

TILccit commented Nov 6, 2024

I am getting the same error: The sample-sheet only contains tumor-samples, but the following tools, which were requested by the option "tools", expect at least one normal-sample : ascat

Any possible solution?

@asp8200
Copy link
Contributor Author

asp8200 commented Nov 6, 2024

I am getting the same error: The sample-sheet only contains tumor-samples, but the following tools, which were requested by the option "tools", expect at least one normal-sample : ascat

Any possible solution?

Is there another error message besides the one related to the sample-sheet? The error message might not be printed to stdout. I would also check .nextflow.log.

@TILccit
Copy link

TILccit commented Nov 6, 2024

No error message. My job terminates with the following

WARN: The default Panel-of-Normals provided by GATK is used for Mutect2.
It is highly recommended to generate one from normal samples that are technical similar to the tumor ones.
For more information: https://gatk.broadinstitute.org/hc/en-us/articles/360035890631-Panel-of-Normals-PON-
[- ] NFCORE_SAREK:PREPARE_GENOME:BWAMEM1_INDEX -
[- ] NFCORE_SAREK:PREPARE_GENOME:BWAMEM2_INDEX -
[- ] NFCORE_SAREK:PREPARE_GENOME:DRAGMAP_HASHTABLE -
[- ] NFCORE_SAREK:PREPARE_GENOME:GATK4_CREATESEQUENCEDICTIONARY -
[- ] NFCORE_SAREK:PREPARE_GENOME:MSISENSORPRO_SCAN -
[- ] NFCORE_SAREK:PREPARE_GENOME:SAMTOOLS_FAIDX -
[- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_BCFTOOLS_ANNOTATIONS -
[- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_DBSNP -
[- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_GERMLINE_RESOURCE -
[- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_KNOWN_SNPS -
[- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_KNOWN_INDELS -
[- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_PON -
[- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_ALLELES -
[- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_LOCI -
[- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_GC -
[- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_RT -
The sample-sheet only contains normal-samples, but the following tools, which were requested with "--tools", expect at least one tumor-sample : ascat, controlfreec, mutect2
Missing process or function Channel.empty([[]])

-- Check script '/home/sarek/.nextflow/assets/nf-core/sarek/main.nf' at line: 342 or see '/mnt/f/ARIA/sarek_output/log/M14TIL121.log' file for more details
The sample-sheet only contains tumor-samples, but the following tools, which were requested by the option "tools", expect at least one normal-sample : ascat

@asp8200
Copy link
Contributor Author

asp8200 commented Nov 6, 2024

No error message. My job terminates with the following

WARN: The default Panel-of-Normals provided by GATK is used for Mutect2. It is highly recommended to generate one from normal samples that are technical similar to the tumor ones. For more information: https://gatk.broadinstitute.org/hc/en-us/articles/360035890631-Panel-of-Normals-PON- [- ] NFCORE_SAREK:PREPARE_GENOME:BWAMEM1_INDEX - [- ] NFCORE_SAREK:PREPARE_GENOME:BWAMEM2_INDEX - [- ] NFCORE_SAREK:PREPARE_GENOME:DRAGMAP_HASHTABLE - [- ] NFCORE_SAREK:PREPARE_GENOME:GATK4_CREATESEQUENCEDICTIONARY - [- ] NFCORE_SAREK:PREPARE_GENOME:MSISENSORPRO_SCAN - [- ] NFCORE_SAREK:PREPARE_GENOME:SAMTOOLS_FAIDX - [- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_BCFTOOLS_ANNOTATIONS - [- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_DBSNP - [- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_GERMLINE_RESOURCE - [- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_KNOWN_SNPS - [- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_KNOWN_INDELS - [- ] NFCORE_SAREK:PREPARE_GENOME:TABIX_PON - [- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_ALLELES - [- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_LOCI - [- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_GC - [- ] NFCORE_SAREK:PREPARE_GENOME:UNZIP_RT - The sample-sheet only contains normal-samples, but the following tools, which were requested with "--tools", expect at least one tumor-sample : ascat, controlfreec, mutect2 Missing process or function Channel.empty([[]])

-- Check script '/home/sarek/.nextflow/assets/nf-core/sarek/main.nf' at line: 342 or see '/mnt/f/ARIA/sarek_output/log/M14TIL121.log' file for more details The sample-sheet only contains tumor-samples, but the following tools, which were requested by the option "tools", expect at least one normal-sample : ascat

Which version of Nextflow are you using? 24.07.0-edge or later? If so, you can try to revert to 24.04.4like this:

NXF_VER=24.04.4 nextflow run … <your parameters here>

If your running local code, then you can perhaps also try the fix mentioned here.

@TILccit
Copy link

TILccit commented Nov 6, 2024

I was using nextflow 24.10.0 but now running again with NXF_VER=24.04.4 nextflow run … and seems working...

Thank you..

Plus 81 more processes waiting for tasks…
[- ] NFCORE_SAREK:SAREK:CONVERT_FASTQ_INPUT:SAMTOOLS_VIEW_MAP_MAP -
[- ] NFCORE_SAREK:SAREK:CONVERT_FASTQ_INPUT:SAMTOOLS_VIEW_UNMAP_UNMAP -
[- ] NFCORE_SAREK:SAREK:CONVERT_FASTQ_INPUT:SAMTOOLS_VIEW_UNMAP_MAP -
[- ] NFCORE_SAREK:SAREK:CONVERT_FASTQ_INPUT:SAMTOOLS_VIEW_MAP_UNMAP -
[a2/a8920c] NFCORE_SAREK:SAREK:FASTQC (121_healthy-1) [ 0%] 0 of 2
[- ] NFCORE_SAREK:SAREK:FASTP [ 0%] 0 of 2
Plus 81 more processes waiting for tasks…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@dansteiert @asp8200 @TILccit and others