-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bbmap clumpify #52
base: dev
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution and working on this task!
Unfortunately, I am missing any configuration for this module. This is highly relevant for two reasons:
1.) The publishDir
directive: Initially, we had decided that Seqinspector would only inspect reads, but not alter them in any way (e.g. perform adapter-trimming) However, I agree that it is convenient to be able to perform some basic error correction and optimization in the process as well. Therefore, I support the addition of such a step, but you need to publish the resulting files so they are available later in the output directory.
2.) Currently, there are no arguments defined for the tool. Particularly for tools from the BBMap Suite, the sheer amount of settings can be overwhelming, but the arguments are also very useful for advanced customization. Please read through the description of arguments and propose some decent defaults. Hint: Consider predominantly k
, subs
, lowcomplexity
and reorder
. If you would like to enable deduplication (dedupe=t
) as well, choices for dupedist
, scanlimit
, spantiles
, adjacent
and optical
must be made.
added clumpify module to the pipeline.
not sure if any of its outputs goes into multiqc (other than version).
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).