Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline tests for different protocols #366

Open
apeltzer opened this issue Jul 30, 2024 · 8 comments
Open

Improve pipeline tests for different protocols #366

apeltzer opened this issue Jul 30, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@apeltzer
Copy link
Member

Description of feature

Should be done in two steps:

@apeltzer apeltzer added the enhancement New feature or request label Jul 30, 2024
@lpantano
Copy link
Contributor

lpantano commented Aug 2, 2024

this could be an option, can you take a look and see if we can use some of these samples:

https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE149513

and script confirming the trimming:

https://github.com/besarka16/Benchmarking-of-small-RNA-seq/blob/master/scripts/1_trimming.sh

@apeltzer apeltzer added this to the 2.4.0 milestone Aug 8, 2024
@apeltzer
Copy link
Member Author

apeltzer commented Aug 8, 2024

Looks like we can use these to me - lets see how easy it would be to add these to nf-core/testdatasets and then run them using the profiles. Shouldn't be too hard and we can get some proper tests then running.

@lpantano
Copy link
Contributor

lpantano commented Aug 9, 2024

that would be great!

@atrigila
Copy link

Hi @lpantano, we are having some issues in CI testing due to, what I think is, making several requests from mirBase. Is it possible to use any other source for the hairpin.fa and the mature.fa? Ideally, we would host the data in the nf-core test-dataset repository if the licence allows for it. For example, could we use RNAcentral? Is it possible to obtain equivalent datasets from this source?
Thank you!

cc @nschcolnicov

@lpantano
Copy link
Contributor

as far as I know, tools need those file from miRBase, we could potentially put them nf-core test-dataset, I don't think the license is a problem. I don't see anything in their webpage that will limit that. I think the hairpin.fa is the only one in RNAcentral, but as well we will need the GFF file from miRBase and the mature.

@apeltzer
Copy link
Member Author

If the licence is no problem, we can certainly dump this on S3 and use that URl.

@atrigila
Copy link

@nschcolnicov Nico wrote an E-mail to confirm license

@nschcolnicov
Copy link

Yes! I sent an email to '[email protected]' last week, but I'm not sure when I will get an answer, I'll update this ticket as soon as I have news

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

4 participants