-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Data Nodes #93
Conversation
I understand this as a nice additional feature, not a must.
Little off topic, but I'm wondering, wouldn't it then be consequent to remove the "artificial" complexity from Source / Sample / Material nodes as well (plus adding a similar layer to allow annotating the type of sample just like the format of data)? |
I've heard this kind of comment a few times now. IMO in order to actually produce a machine actionable representation of a research cycle, this is definitely a MUST. If this is not given, associating data to the samples it was measured from will remain implicit. With all the other points I agree. |
We will need some great tooling though to allow both programmers and wet lab researchers to create these selectors without much hassle. |
Totally agree. I just thought that's what the ISA extension with isa.dataset.xlsx is good for |
The selector will be part both of the So the two additions will work together but not fulfilling the same task. |
Having talked about this with @HLWeil in person, I agree with this approach. |
Data Selectors
This PR includes the specification for annotating not only full data resources, but parts of it. For this, after specifying the
resource location
, aselector
can be appended, separated by a#
.This design is heavily inspired by data fragment selectors that can be found in URLs and has two-fold advantage over the solution proposed in #80 (comment), where the selector is moved into another column:
To support non-standard cases and increase verbosity, two qualifying columns were added, closely following the proposal made by @stain in ISA-tools/isa-specs#15 (comment). This goes in line with Schema.org/CreativeWork and by this I hope to increase compatiblity with RO-Crate.
Data Category annotation
Additionally, for specifying the
Input
andOutput
of an annotation table, I cut out all distinctions about the content of theData
resource (Raw Data File
,Derived Data File
andImage File
). This is in line with many discussion about this topic, with the conclusion that this distinction is kind of artificial. I also went againstData File
andData Directory
as again, this distinction tries to increase information, but by design excludes cases that do not fall under these categories.Any input would be welcome
@kappe-c @chgarth @muehlhaus @Brilator