-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Run Selenium in Docker #163
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, added env variables
…or debugging (remove before merging)
…t project, added ssl certs for *.example.localhost
… cert is good for *.example.localhost, not example.localhost)
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 37
Lines ? 1176
Branches ? 0
=======================================
Hits ? 1176
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #142. Currently only works when you change the command from "dev" to "test:e2e" in example/docker-compose.override.yml
If we run
npm run test:e2e
on a wildcat container running in dev mode, the end to end tests run against dev mode instead of prod-local mode. We have to figure out a way to get the tests to run against prod-local mode even if dev mode is already running.