feat(abc:onboarding): support standalone

ng-alain · Jan 11, 2024 · 90a1392 · 90a1392
1 parent 5ac646c
commit 90a1392
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 12 deletions.
diff --git a/packages/abc/observers/index.en-US.md b/packages/abc/observers/index.en-US.md
@@ -9,7 +9,7 @@ The `ObserversModule` package provides convenience directives built on top of na
 
 ## API
 
-### [observeSize]
+### [observeSize]:standalone
 
 Watch the DOM size change.
 

diff --git a/packages/abc/observers/index.zh-CN.md b/packages/abc/observers/index.zh-CN.md
@@ -10,7 +10,7 @@ module: import { ObserversModule } from '@delon/abc/observers';
 
 ## API
 
-### [observeSize]
+### [observeSize]:standalone
 
 观察DOM大小变化。
 

diff --git a/packages/abc/onboarding/demo/basic.md b/packages/abc/onboarding/demo/basic.md
@@ -16,7 +16,7 @@ Simplest of usage.
 ```ts
 import { Component, inject } from '@angular/core';
 
-import { OnboardingConfig, OnboardingModule, OnboardingService } from '@delon/abc/onboarding';
+import { OnboardingConfig, OnboardingService } from '@delon/abc/onboarding';
 import { _HttpClient } from '@delon/theme';
 import { NzButtonModule } from 'ng-zorro-antd/button';
 import { NzMessageService } from 'ng-zorro-antd/message';
@@ -41,7 +41,7 @@ import { NzMessageService } from 'ng-zorro-antd/message';
     </a>
   `,
   standalone: true,
-  imports: [NzButtonModule, OnboardingModule]
+  imports: [NzButtonModule]
 })
 export class DemoComponent {
   private readonly msg = inject(NzMessageService);

diff --git a/packages/abc/onboarding/demo/multiple-pages.md b/packages/abc/onboarding/demo/multiple-pages.md
@@ -16,7 +16,7 @@ Use `url` to change the routing, it's recommended to use `before` to delay, othe
 ```ts
 import { Component, inject } from '@angular/core';
 
-import { OnboardingModule, OnboardingService } from '@delon/abc/onboarding';
+import { OnboardingService } from '@delon/abc/onboarding';
 import { _HttpClient } from '@delon/theme';
 import { NzButtonModule } from 'ng-zorro-antd/button';
 
@@ -30,7 +30,7 @@ import { NzButtonModule } from 'ng-zorro-antd/button';
     <button nz-button (click)="start()">Start</button>
   `,
   standalone: true,
-  imports: [NzButtonModule, OnboardingModule]
+  imports: [NzButtonModule]
 })
 export class DemoComponent {
   private readonly srv = inject(OnboardingService);

diff --git a/packages/abc/onboarding/onboarding.component.ts b/packages/abc/onboarding/onboarding.component.ts
@@ -15,6 +15,8 @@ import {
   ViewEncapsulation
 } from '@angular/core';
 
+import { NzButtonComponent } from 'ng-zorro-antd/button';
+import { NzStringTemplateOutletDirective } from 'ng-zorro-antd/core/outlet';
 import type { NzSafeAny } from 'ng-zorro-antd/core/types';
 import { NzPopoverDirective } from 'ng-zorro-antd/popover';
 
@@ -40,7 +42,9 @@ interface OnboardingLightData {
   },
   preserveWhitespaces: false,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  encapsulation: ViewEncapsulation.None
+  encapsulation: ViewEncapsulation.None,
+  standalone: true,
+  imports: [NzPopoverDirective, NzStringTemplateOutletDirective, NzButtonComponent]
 })
 export class OnboardingComponent implements OnDestroy, AfterViewInit {
   private time: NzSafeAny;

diff --git a/packages/abc/onboarding/onboarding.module.ts b/packages/abc/onboarding/onboarding.module.ts
@@ -8,14 +8,19 @@ import { NzOutletModule } from 'ng-zorro-antd/core/outlet';
 import { NzPopoverModule } from 'ng-zorro-antd/popover';
 
 import { OnboardingComponent } from './onboarding.component';
-import { OnboardingService } from './onboarding.service';
 
 const COMPONENTS = [OnboardingComponent];
 
 @NgModule({
-  imports: [CommonModule, DelonLocaleModule, NzPopoverModule, NzOutletModule, NzButtonModule, NzNoAnimationModule],
-  declarations: COMPONENTS,
-  providers: [OnboardingService],
+  imports: [
+    CommonModule,
+    DelonLocaleModule,
+    NzPopoverModule,
+    NzOutletModule,
+    NzButtonModule,
+    NzNoAnimationModule,
+    COMPONENTS
+  ],
   exports: COMPONENTS
 })
 export class OnboardingModule {}
diff --git a/packages/abc/onboarding/onboarding.service.ts b/packages/abc/onboarding/onboarding.service.ts
@@ -21,7 +21,7 @@ import { OnboardingComponent } from './onboarding.component';
 import { ONBOARDING_STORE_TOKEN, OnBoardingKeyStore } from './onboarding.storage';
 import { OnboardingConfig, OnboardingItem, OnboardingOpType } from './onboarding.types';
 
-@Injectable()
+@Injectable({ providedIn: 'root' })
 export class OnboardingService implements OnDestroy {
   private compRef!: ComponentRef<OnboardingComponent>;
   private op$!: Subscription;