Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abc:cell): add cell component #1530

Merged
merged 46 commits into from
Aug 28, 2023
Merged

feat(abc:cell): add cell component #1530

merged 46 commits into from
Aug 28, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 14, 2022

Preview is ready!

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1530 (dcf89f9) into master (d815dbd) will increase coverage by 0.05%.
The diff coverage is 98.33%.

❗ Current head dcf89f9 differs from pull request most recent head 6dfba8a. Consider uploading reports for the commit 6dfba8a to get more accurate results

@@            Coverage Diff             @@
##           master    #1530      +/-   ##
==========================================
+ Coverage   95.51%   95.56%   +0.05%     
==========================================
  Files         277      281       +4     
  Lines        8561     8726     +165     
  Branches     1682     1726      +44     
==========================================
+ Hits         8177     8339     +162     
  Misses        319      319              
- Partials       65       68       +3     
Files Changed Coverage Δ
packages/abc/st/st.module.ts 100.00% <ø> (ø)
packages/util/config/config.types.ts 100.00% <ø> (ø)
packages/util/format/currency.types.ts 100.00% <ø> (ø)
packages/abc/cell/cell.service.ts 97.43% <97.43%> (ø)
packages/abc/cell/cell.component.ts 98.36% <98.36%> (ø)
packages/abc/cell/cell-host.directive.ts 100.00% <100.00%> (ø)
packages/abc/cell/cell.module.ts 100.00% <100.00%> (ø)
packages/abc/st/st-column-source.ts 99.65% <100.00%> (+<0.01%) ⬆️
packages/abc/st/st-data-source.ts 100.00% <100.00%> (ø)
packages/theme/src/pipes/date/date.pipe.ts 100.00% <100.00%> (ø)
... and 2 more

@cipchk cipchk removed the PR: draft label Sep 15, 2022
@cipchk cipchk changed the title draft: feat(abc:cell): add cell component feat(abc:cell): add cell component Sep 15, 2022
@cipchk cipchk merged commit 26023ca into master Aug 28, 2023
8 checks passed
@cipchk cipchk deleted the issuse-cell branch August 28, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants