Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:reuse-tab): fix cache #1611

Merged
merged 1 commit into from
Jul 16, 2023
Merged

fix(abc:reuse-tab): fix cache #1611

merged 1 commit into from
Jul 16, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 16, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 16, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #1611 (b428e54) into master (cd91a5a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b428e54 differs from pull request most recent head b0aa49e. Consider uploading reports for the commit b0aa49e to get more accurate results

@@           Coverage Diff           @@
##           master    #1611   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         277      277           
  Lines        8522     8523    +1     
  Branches     1667     1667           
=======================================
+ Hits         8140     8141    +1     
  Misses        317      317           
  Partials       65       65           
Impacted Files Coverage Δ
packages/abc/reuse-tab/reuse-tab.service.ts 98.86% <100.00%> (+<0.01%) ⬆️

@cipchk cipchk merged commit 3185ab8 into master Jul 16, 2023
6 of 8 checks passed
@cipchk cipchk deleted the issues-hot-fix branch January 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants