Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): refactor CanActivate to CanActivateFn #1623

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 21, 2023

  • refactor ACLGuard to aclCanMatch, aclCanActivate, aclCanActivateChild

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

-  refactor `ACLGuard` to `aclCanMatch`, `aclCanActivate`, `aclCanActivateChild`
@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 21, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1623 (edca27d) into master (b565ddf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head edca27d differs from pull request most recent head 1fc362e. Consider uploading reports for the commit 1fc362e to get more accurate results

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   95.54%   95.56%   +0.01%     
==========================================
  Files         277      277              
  Lines        8624     8605      -19     
  Branches     1681     1681              
==========================================
- Hits         8240     8223      -17     
+ Misses        319      317       -2     
  Partials       65       65              
Impacted Files Coverage Δ
packages/acl/src/acl.module.ts 100.00% <ø> (ø)
packages/acl/src/acl-guard.ts 100.00% <100.00%> (ø)
packages/auth/src/token/jwt/jwt.guard.ts 100.00% <100.00%> (ø)
packages/auth/src/token/simple/simple.guard.ts 100.00% <100.00%> (ø)
packages/theme/src/services/i18n/i18n-url.guard.ts 100.00% <100.00%> (+15.38%) ⬆️

@cipchk cipchk merged commit 66b358f into master Jul 21, 2023
8 checks passed
@cipchk cipchk deleted the issues-refactor-router-can branch July 21, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants