Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abc:onboarding): fix ComponentFactoryResolver #1624

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix(abc:onboarding): fix ComponentFactoryResolver #1624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cee67d
fix(abc:onboarding): fix `ComponentFactoryResolver`
cipchk Jul 21, 2023
440afae
chore: merge branch 'master' into issues-ComponentFactoryResolver
cipchk Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/abc/onboarding/onboarding.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ import { Directionality } from '@angular/cdk/bidi';
import { DOCUMENT } from '@angular/common';
import {
ApplicationRef,
ComponentFactoryResolver,
ComponentRef,
EmbeddedViewRef,
Inject,
Injectable,
Injector,
OnDestroy,
Optional
Optional,
createComponent
} from '@angular/core';
import { Router } from '@angular/router';
import { of, pipe, Subscription, delay, switchMap } from 'rxjs';
Expand Down Expand Up @@ -47,17 +46,17 @@ export class OnboardingService implements OnDestroy {
constructor(
private i18n: DelonLocaleService,
private appRef: ApplicationRef,
// TODO: Tracking https://github.com/angular/angular/issues/45263
private resolver: ComponentFactoryResolver,
private router: Router,
private injector: Injector,
@Inject(DOCUMENT) private doc: NzSafeAny,
private configSrv: AlainConfigService,
@Optional() private directionality: Directionality
) {}

private attach(): void {
const compRef = (this.compRef = this.resolver.resolveComponentFactory(OnboardingComponent).create(this.injector));
const compRef = createComponent(OnboardingComponent, {
environmentInjector: this.appRef.injector
});
this.compRef = compRef;
this.appRef.attachView(compRef.hostView);
const compNode = (compRef.hostView as EmbeddedViewRef<NzSafeAny>).rootNodes[0];
const doc = this._getDoc();
Expand Down