Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme:modal): add size support percentage #1626

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 21, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1626 (809500d) into master (a171d50) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 809500d differs from pull request most recent head 17c279c. Consider uploading reports for the commit 17c279c to get more accurate results

@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
+ Coverage   95.56%   95.57%   +0.01%     
==========================================
  Files         277      277              
  Lines        8604     8605       +1     
  Branches     1681     1682       +1     
==========================================
+ Hits         8222     8224       +2     
  Misses        317      317              
+ Partials       65       64       -1     
Impacted Files Coverage Δ
packages/theme/src/services/modal/modal.helper.ts 82.14% <100.00%> (+2.14%) ⬆️

@cipchk cipchk changed the title feat(theme:modal): support size support percentage feat(theme:modal): add size support percentage Jul 21, 2023
@cipchk cipchk merged commit 8b52a08 into master Aug 28, 2023
8 checks passed
@cipchk cipchk deleted the issues-modal-size-% branch August 28, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants