Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(abc:st): use Observable instead of Promise of load #1637

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Aug 4, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1637 (c4ef806) into master (d815dbd) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head c4ef806 differs from pull request most recent head 98c0b67. Consider uploading reports for the commit 98c0b67 to get more accurate results

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
- Coverage   95.51%   95.48%   -0.03%     
==========================================
  Files         277      277              
  Lines        8561     8553       -8     
  Branches     1682     1683       +1     
==========================================
- Hits         8177     8167      -10     
- Misses        319      320       +1     
- Partials       65       66       +1     
Files Changed Coverage Δ
packages/abc/st/st-data-source.ts 100.00% <100.00%> (ø)
packages/abc/st/st.component.ts 99.78% <100.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Aug 4, 2023

Preview is ready!

@cipchk cipchk merged commit 5d9bdef into master Aug 28, 2023
8 checks passed
@cipchk cipchk deleted the issues-2233 branch August 28, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(abc:st): use Observable instead of Promise of load
2 participants