Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme:title): fix ignore empty title #1638

Merged
merged 1 commit into from
Aug 5, 2023
Merged

fix(theme:title): fix ignore empty title #1638

merged 1 commit into from
Aug 5, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Aug 5, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #1638 (f5b7759) into master (d815dbd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f5b7759 differs from pull request most recent head 4893652. Consider uploading reports for the commit 4893652 to get more accurate results

@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         277      277           
  Lines        8561     8561           
  Branches     1682     1682           
=======================================
  Hits         8177     8177           
  Misses        319      319           
  Partials       65       65           
Files Changed Coverage Δ
packages/theme/src/services/title/title.service.ts 100.00% <100.00%> (ø)

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Aug 5, 2023

Preview is ready!

@cipchk cipchk merged commit c7bf339 into master Aug 5, 2023
8 checks passed
@cipchk cipchk deleted the issues-title branch August 5, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants